Bug 140355 - AX: [ATK] Mark accessibility/table-with-footer-section-above-body.html as a suitable test for EFL and GTK
Summary: AX: [ATK] Mark accessibility/table-with-footer-section-above-body.html as a s...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-01-12 04:43 PST by Andrzej Badowski
Modified: 2015-01-13 05:14 PST (History)
3 users (show)

See Also:

Attachments
proposed patch (5.17 KB, patch)
2015-01-12 05:13 PST, Andrzej Badowski 		no flags Details | Formatted Diff | Diff
proposed patch 2 (4.79 KB, patch)
2015-01-12 05:22 PST, Andrzej Badowski 		cfleizach: review+
Details | Formatted Diff | Diff
proposed patch 3 (4.88 KB, patch)
2015-01-13 01:16 PST, Andrzej Badowski 		commit-queue: commit-queue-
Details | Formatted Diff | Diff
proposed patch 4 (4.75 KB, patch)
2015-01-13 03:48 PST, Andrzej Badowski 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrzej Badowski 2015-01-12 04:43:05 PST 
The test shows the text contents of a AccessibilityTableCell object using tableCell.childAtIndex(0).stringValue. In the case of ATK childAtIndex(0) returns a non-empty object, but it is not the ATK_OBJECT, so the stringValue produces an empty string. To avoid this, the cell text content is obtained by direct reading of stringValue of TableCell.
Comment 1 Radar WebKit Bug Importer 2015-01-12 04:43:19 PST 
<rdar://problem/19442319>
Comment 2 Andrzej Badowski 2015-01-12 05:13:24 PST 
Created attachment 244442 [details]
proposed patch
Comment 3 Andrzej Badowski 2015-01-12 05:22:55 PST 
Created attachment 244443 [details]
proposed patch 2
Comment 4 chris fleizach 2015-01-12 11:41:54 PST 
Comment on attachment 244443 [details]
proposed patch 2

View in context: https://bugs.webkit.org/attachment.cgi?id=244443&action=review

> LayoutTests/ChangeLog:8
> +        The test shows the text contents of a AccessibilityTableCell object using tableCell.childAtIndex(0).stringValue.

of "an" AccessibilityTableCell
Comment 5 Andrzej Badowski 2015-01-13 01:16:24 PST 
Created attachment 244501 [details]
proposed patch 3
Comment 6 WebKit Commit Bot 2015-01-13 03:31:37 PST 
Comment on attachment 244501 [details]
proposed patch 3

Rejecting attachment 244501 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 244501, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.

Full output: http://webkit-queues.appspot.com/results/5692178365939712
Comment 7 Andrzej Badowski 2015-01-13 03:48:44 PST 
Created attachment 244505 [details]
proposed patch 4
Comment 8 WebKit Commit Bot 2015-01-13 05:14:14 PST 
Comment on attachment 244505 [details]
proposed patch 4

Clearing flags on attachment: 244505

Committed r178362: <http://trac.webkit.org/changeset/178362>
Comment 9 WebKit Commit Bot 2015-01-13 05:14:19 PST 
All reviewed patches have been landed.  Closing bug.