Bug 140353 - [GTK] Do not resize the redirected XComposite window when not in accelerated compositing mode
Summary: [GTK] Do not resize the redirected XComposite window when not in accelerated ...
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Keywords: Gtk
Depends on:
Reported: 2015-01-12 02:40 PST by Carlos Garcia Campos
Modified: 2015-01-14 01:00 PST (History)
5 users (show)

See Also:

Patch (4.07 KB, patch)
2015-01-12 02:46 PST, Carlos Garcia Campos
mrobinson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2015-01-12 02:40:09 PST
We create the redirected XComposite window unconditionally, but with a size of 1x1 to save memory. However, we are always resizing it, so in the end we always end up with a XWindow allocated for the same size of the web view, even for web views that never enter in AC mode.
Comment 1 Carlos Garcia Campos 2015-01-12 02:46:24 PST
Created attachment 244438 [details]

Before this patch a MiniBrowser opened with the default size and URL required 11.2MB, and with the patch it requires 9.5MB.
Comment 2 WebKit Commit Bot 2015-01-12 02:48:50 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Carlos Garcia Campos 2015-01-14 01:00:21 PST
Committed r178414: <http://trac.webkit.org/changeset/178414>