Bug 140346 - Enable Vector bounds checking for ElementDescendantIterator.
Summary: Enable Vector bounds checking for ElementDescendantIterator.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-11 19:22 PST by Andreas Kling
Modified: 2016-02-19 15:04 PST (History)
5 users (show)

See Also:


Attachments
Patch (1.31 KB, patch)
2015-01-11 19:24 PST, Andreas Kling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2015-01-11 19:22:17 PST
I had originally disabled Vector bounds checking for ElementDescendantIterator's internal ancestor stack, but upon re-running performance benchmarks, it appears to have little-to-no measurable benefit.

Let's add it back.
Comment 1 Andreas Kling 2015-01-11 19:24:10 PST
Created attachment 244430 [details]
Patch
Comment 2 Alexey Proskuryakov 2015-01-11 20:12:49 PST
Thank you!
Comment 3 WebKit Commit Bot 2015-01-11 20:33:38 PST
Comment on attachment 244430 [details]
Patch

Clearing flags on attachment: 244430

Committed r178253: <http://trac.webkit.org/changeset/178253>
Comment 4 WebKit Commit Bot 2015-01-11 20:33:43 PST
All reviewed patches have been landed.  Closing bug.