RESOLVED FIXED 140332
Update the output format for run-api-tests 
https://bugs.webkit.org/show_bug.cgi?id=140332
Summary Update the output format for run-api-tests
Sam Weinig
Reported 2015-01-09 21:23:48 PST
Update the output format for TestWebKitAPI
Attachments
Patch (7.49 KB, patch)
2015-01-09 21:29 PST, Sam Weinig 		mitz: review+
DetailsFormatted DiffDiff
Sample Output (170.36 KB, image/png)
2015-01-09 21:31 PST, Sam Weinig 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2015-01-09 21:29:31 PST
Created attachment 244403 [details] Patch
Sam Weinig
Comment 2 2015-01-09 21:31:36 PST
Created attachment 244404 [details] Sample Output Attaching a screenshot of what the new output looks like, including one simulated failure.
mitz
Comment 3 2015-01-09 23:27:15 PST
Comment on attachment 244403 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=244403&action=review > Tools/ChangeLog:9 > + indented based on suite, as we were no really using suite very well) but Typo: “no really” > Tools/ChangeLog:20 > + Augment the custom gtest printer by replacing the tokens "**PASS**" and "**FAIL**" > + with colorized variants and strip out leaks spew (the leaks can be added back using > + the new --show-leaks argument). Are the colors going to be a problem when looking at things like buildbot output? > Tools/Scripts/run-api-tests:185 > + Why?
Sam Weinig
Comment 4 2015-01-09 23:48:41 PST
(In reply to comment #3) > Comment on attachment 244403 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=244403&action=review > > > Tools/ChangeLog:9 > > + indented based on suite, as we were no really using suite very well) but > > Typo: “no really” > > > Tools/ChangeLog:20 > > + Augment the custom gtest printer by replacing the tokens "**PASS**" and "**FAIL**" > > + with colorized variants and strip out leaks spew (the leaks can be added back using > > + the new --show-leaks argument). > > Are the colors going to be a problem when looking at things like buildbot > output? I don't know. But if they are, I will add an option to remove them. > > > Tools/Scripts/run-api-tests:185 > > + > > Why? open3 is weird. If you pass 0 handle to the stderr parameter it will send stderr to the stdout handle, which is what I want in the verbose or leak printing case. In the non-verbose case, we can send stderr to devnull
Sam Weinig
Comment 5 2015-01-10 00:01:31 PST
Committed r178236: <http://trac.webkit.org/changeset/178236>
Note You need to log in before you can comment on or make changes to this bug.