Bug 140312 - Cache-control should be set only on api/runs
Summary: Cache-control should be set only on api/runs
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Website (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
Depends on:
Reported: 2015-01-09 14:32 PST by Ryosuke Niwa
Modified: 2015-01-09 14:39 PST (History)
0 users

See Also:

Fixes the bug (3.72 KB, patch)
2015-01-09 14:37 PST, Ryosuke Niwa
kling: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2015-01-09 14:32:41 PST
Some JSON APIs such as api/analysis-tasks can get outdated pretty quickly as they could be modified by the user on demand.
Since the only JSON that takes a long time to generate is ones returned by api/runs, just set cache-control in that script instead.
Comment 1 Ryosuke Niwa 2015-01-09 14:37:16 PST
Created attachment 244372 [details]
Fixes the bug
Comment 2 Andreas Kling 2015-01-09 14:38:10 PST
Comment on attachment 244372 [details]
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=244372&action=review


> Websites/perf.webkit.org/public/api/runs.php:18
> +// FIXME: We should support revalication as well as caching results in the server side.

Typo, revalidation.
Comment 3 Ryosuke Niwa 2015-01-09 14:39:30 PST
Committed r178208: <http://trac.webkit.org/changeset/178208>