Bug 140302 - Allow HTTPS + 'Cache-control: no-store' sub-frames into the page cache
Summary: Allow HTTPS + 'Cache-control: no-store' sub-frames into the page cache
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-09 11:33 PST by Chris Dumez
Modified: 2015-01-09 12:59 PST (History)
6 users (show)

See Also:

Attachments
Patch (7.36 KB, patch)
2015-01-09 11:39 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (7.12 KB, patch)
2015-01-09 12:19 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2015-01-09 11:33:48 PST 
We should allow HTTPS + 'Cache-control: no-store' sub-frames into the page cache. We already restore 'no-store' sub-resources on history navigation from the memory cache so there is no reason for our page cache policy to be more restrictive.
We should align our memory cache / history navigation policy with our page cache policy.

For now, 'no-store' main resources are not restored from either cache (memory cache / page cache) on history navigation though. This behavior does not change.
Comment 1 Chris Dumez 2015-01-09 11:39:24 PST 
Created attachment 244355 [details]
Patch
Comment 2 Andreas Kling 2015-01-09 12:11:36 PST 
Comment on attachment 244355 [details]
Patch

r=me
Comment 3 Chris Dumez 2015-01-09 12:19:34 PST 
Created attachment 244364 [details]
Patch
Comment 4 WebKit Commit Bot 2015-01-09 12:59:06 PST 
Comment on attachment 244364 [details]
Patch

Clearing flags on attachment: 244364

Committed r178191: <http://trac.webkit.org/changeset/178191>
Comment 5 WebKit Commit Bot 2015-01-09 12:59:11 PST 
All reviewed patches have been landed.  Closing bug.