Bug 140291 - Web Inspector: REGRESSION: Navigation sidebar can show blank next to the Console view
Summary: Web Inspector: REGRESSION: Navigation sidebar can show blank next to the Cons...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-01-09 08:10 PST by Timothy Hatcher
Modified: 2015-01-09 12:08 PST (History)
8 users (show)

See Also:

Attachments
Patch (5.41 KB, patch)
2015-01-09 08:14 PST, Timothy Hatcher 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2015-01-09 08:10:23 PST 
After http://trac.webkit.org/changeset/178155 I have sometimes seen the navigation sidebar appear on launch when restoring to the Console view. Not sure what the steps are, but I have a patch to avoid it.
Comment 1 Radar WebKit Bug Importer 2015-01-09 08:10:46 PST 
<rdar://problem/19426210>
Comment 2 Timothy Hatcher 2015-01-09 08:14:54 PST 
Created attachment 244343 [details]
Patch
Comment 3 Joseph Pecoraro 2015-01-09 11:17:10 PST 
Comment on attachment 244343 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=244343&action=review

> Source/WebInspectorUI/UserInterface/Base/Main.js:975
> +        this._ignoreNavigationSidebarPanelCollapsedEvent = true;
> +        this.navigationSidebar.collapsed = true;
> +        delete this._ignoreNavigationSidebarPanelCollapsedEvent;

I wonder if we should just set _ignore to false instead of deleting it. That would mean that later, the property lookup doesn't need to walk the prototype chain, and should just find the property immediately.

> Source/WebInspectorUI/UserInterface/Base/Main.js:979
> +    // Restore the sidebar if was forced collapsed earlier because of no selectedSidebarPanel.

Grammar: "if was forced" => "if it was forced"
Comment 4 WebKit Commit Bot 2015-01-09 12:08:54 PST 
Comment on attachment 244343 [details]
Patch

Clearing flags on attachment: 244343

Committed r178184: <http://trac.webkit.org/changeset/178184>
Comment 5 WebKit Commit Bot 2015-01-09 12:08:58 PST 
All reviewed patches have been landed.  Closing bug.