RESOLVED FIXED 140291
Web Inspector: REGRESSION: Navigation sidebar can show blank next to the Console view 
https://bugs.webkit.org/show_bug.cgi?id=140291
Summary Web Inspector: REGRESSION: Navigation sidebar can show blank next to the Cons...
Timothy Hatcher
Reported 2015-01-09 08:10:23 PST
After http://trac.webkit.org/changeset/178155 I have sometimes seen the navigation sidebar appear on launch when restoring to the Console view. Not sure what the steps are, but I have a patch to avoid it.
Attachments
Patch (5.41 KB, patch)
2015-01-09 08:14 PST, Timothy Hatcher 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-01-09 08:10:46 PST
<rdar://problem/19426210>
Timothy Hatcher
Comment 2 2015-01-09 08:14:54 PST
Created attachment 244343 [details] Patch
Joseph Pecoraro
Comment 3 2015-01-09 11:17:10 PST
Comment on attachment 244343 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=244343&action=review > Source/WebInspectorUI/UserInterface/Base/Main.js:975 > + this._ignoreNavigationSidebarPanelCollapsedEvent = true; > + this.navigationSidebar.collapsed = true; > + delete this._ignoreNavigationSidebarPanelCollapsedEvent; I wonder if we should just set _ignore to false instead of deleting it. That would mean that later, the property lookup doesn't need to walk the prototype chain, and should just find the property immediately. > Source/WebInspectorUI/UserInterface/Base/Main.js:979 > + // Restore the sidebar if was forced collapsed earlier because of no selectedSidebarPanel. Grammar: "if was forced" => "if it was forced"
WebKit Commit Bot
Comment 4 2015-01-09 12:08:54 PST
Comment on attachment 244343 [details] Patch Clearing flags on attachment: 244343 Committed r178184: <http://trac.webkit.org/changeset/178184>
WebKit Commit Bot
Comment 5 2015-01-09 12:08:58 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.