Bug 140283 – Add basic pattern matching support to the url filters

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Benjamin Poulain]

Add basic pattern matching support to the url filters

[Benjamin Poulain]

Created attachment 244322 [details]
Patch

[Gavin Barraclough]

Comment on attachment 244322 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=244322&action=review

> Source/WebCore/contentextensions/URLFilterParser.cpp:140
> +    void disjunction() { }

Shouldn't these fail()?

[Benjamin Poulain]

(In reply to comment #2)
> Comment on attachment 244322 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=244322&action=review
> 
> > Source/WebCore/contentextensions/URLFilterParser.cpp:140
> > +    void disjunction() { }
> 
> Shouldn't these fail()?

I can add that. I was just implementing the minimum I need at the moment. Eventually everything except backreference should have an implementation.

[Benjamin Poulain]

Created attachment 244370 [details]
Patch

[Andreas Kling]

Comment on attachment 244370 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=244370&action=review

r=me

> Source/WebCore/contentextensions/URLFilterParser.cpp:70
> +        ASSERT(isASCII(character));

I think this needs a runtime check, there's no guarantee that 'character' will be ASCII.

[Benjamin Poulain]

Committed r178313: <http://trac.webkit.org/changeset/178313>