Bug 140283 - Add basic pattern matching support to the url filters
Summary: Add basic pattern matching support to the url filters
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-08 20:42 PST by Benjamin Poulain
Modified: 2015-01-12 17:37 PST (History)
2 users (show)

See Also:

Attachments
Patch (32.85 KB, patch)
2015-01-08 20:56 PST, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
Patch (33.84 KB, patch)
2015-01-09 14:07 PST, Benjamin Poulain 		kling: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2015-01-08 20:42:31 PST 
Add basic pattern matching support to the url filters
Comment 1 Benjamin Poulain 2015-01-08 20:56:13 PST 
Created attachment 244322 [details]
Patch
Comment 2 Gavin Barraclough 2015-01-09 11:29:03 PST 
Comment on attachment 244322 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=244322&action=review

> Source/WebCore/contentextensions/URLFilterParser.cpp:140
> +    void disjunction() { }

Shouldn't these fail()?
Comment 3 Benjamin Poulain 2015-01-09 11:46:58 PST 
(In reply to comment #2)
> Comment on attachment 244322 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=244322&action=review
> 
> > Source/WebCore/contentextensions/URLFilterParser.cpp:140
> > +    void disjunction() { }
> 
> Shouldn't these fail()?

I can add that. I was just implementing the minimum I need at the moment. Eventually everything except backreference should have an implementation.
Comment 4 Benjamin Poulain 2015-01-09 14:07:53 PST 
Created attachment 244370 [details]
Patch
Comment 5 Andreas Kling 2015-01-09 16:51:43 PST 
Comment on attachment 244370 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=244370&action=review

r=me

> Source/WebCore/contentextensions/URLFilterParser.cpp:70
> +        ASSERT(isASCII(character));

I think this needs a runtime check, there's no guarantee that 'character' will be ASCII.
Comment 6 Benjamin Poulain 2015-01-12 17:37:21 PST 
Committed r178313: <http://trac.webkit.org/changeset/178313>