Bug 140282 – defaultPlaybackRate not respected when set before sourec is loaded

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Jer Noble]

defaultPlaybackRate not respected when set before sourec is loaded

[Jer Noble]

Created attachment 244328 [details]
Patch

[Eric Carlson]

Comment on attachment 244328 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=244328&action=review

> Source/WebCore/html/HTMLMediaElement.cpp:265
> +    , m_playbackRate(1)

This name makes it even less clear what this is used for now that there are 3 rate ivars. I think something like "m_requestedRate" would be better.

> LayoutTests/ChangeLog:3
> +        defaultPlaybackRate not respected when set before sourec is loaded

Typo: sourec -> source

[Jer Noble]

(In reply to comment #2)
> Comment on attachment 244328 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=244328&action=review
> 
> > Source/WebCore/html/HTMLMediaElement.cpp:265
> > +    , m_playbackRate(1)
> 
> This name makes it even less clear what this is used for now that there are
> 3 rate ivars. I think something like "m_requestedRate" would be better.

I originally changed it to m_requestedPlaybackRate, but changed it back.  I'll re-make that change.

> > LayoutTests/ChangeLog:3
> > +        defaultPlaybackRate not respected when set before sourec is loaded
> 
> Typo: sourec -> source

Whoops!

[Jer Noble]

Created attachment 244363 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 244363 [details]
Patch for landing

Clearing flags on attachment: 244363

Committed r178281: <http://trac.webkit.org/changeset/178281>

[Csaba Osztrogonác]

(In reply to comment #5)
> Comment on attachment 244363 [details]
> Patch for landing
> 
> Clearing flags on attachment: 244363
> 
> Committed r178281: <http://trac.webkit.org/changeset/178281>

It broke many tests everywhere:
- Apple Yosemite WK2: https://build.webkit.org/builders/Apple%20Yosemite%20Release%20WK2%20%28Tests%29/builds/1895
-  Apple Yosemite WK1: https://build.webkit.org/builders/Apple%20Yosemite%20Release%20WK1%20%28Tests%29/builds/1904
- GTK: https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Tests%29/builds/5336

[Alexey Proskuryakov]

Yes, I'm going to roll out.

[Jer Noble]

Created attachment 244464 [details]
Patch for landing

Replaced two more instances of 'effectivePlaybackRate()' with 'requsetedPlaybackRate()'.

[Jer Noble]

Created attachment 244466 [details]
Patch for landing

Replaced two more instances of 'effectivePlaybackRate()' with 'requsetedPlaybackRate()'.

[WebKit Commit Bot]

Comment on attachment 244466 [details]
Patch for landing

Clearing flags on attachment: 244466

Committed r178367: <http://trac.webkit.org/changeset/178367>