Bug 140282 - defaultPlaybackRate not respected when set before sourec is loaded
Summary: defaultPlaybackRate not respected when set before sourec is loaded
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords:
Depends on: 140366
Blocks:
  Show dependency tree / graph
 
Reported: 2015-01-08 19:58 PST by Jer Noble
Modified: 2015-02-09 11:02 PST (History)
2 users (show)

See Also:

Attachments
Patch (26.59 KB, patch)
2015-01-08 22:04 PST, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch for landing (27.08 KB, patch)
2015-01-09 12:11 PST, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch for landing (24.45 KB, patch)
2015-01-12 13:48 PST, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch for landing (27.83 KB, patch)
2015-01-12 14:12 PST, Jer Noble 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2015-01-08 19:58:32 PST 
defaultPlaybackRate not respected when set before sourec is loaded
Comment 1 Jer Noble 2015-01-08 22:04:29 PST 
Created attachment 244328 [details]
Patch
Comment 2 Eric Carlson 2015-01-09 10:57:57 PST 
Comment on attachment 244328 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=244328&action=review

> Source/WebCore/html/HTMLMediaElement.cpp:265
> +    , m_playbackRate(1)

This name makes it even less clear what this is used for now that there are 3 rate ivars. I think something like "m_requestedRate" would be better.

> LayoutTests/ChangeLog:3
> +        defaultPlaybackRate not respected when set before sourec is loaded

Typo: sourec -> source
Comment 3 Jer Noble 2015-01-09 11:15:36 PST 
(In reply to comment #2)
> Comment on attachment 244328 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=244328&action=review
> 
> > Source/WebCore/html/HTMLMediaElement.cpp:265
> > +    , m_playbackRate(1)
> 
> This name makes it even less clear what this is used for now that there are
> 3 rate ivars. I think something like "m_requestedRate" would be better.

I originally changed it to m_requestedPlaybackRate, but changed it back.  I'll re-make that change.

> > LayoutTests/ChangeLog:3
> > +        defaultPlaybackRate not respected when set before sourec is loaded
> 
> Typo: sourec -> source

Whoops!
Comment 4 Jer Noble 2015-01-09 12:11:56 PST 
Created attachment 244363 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2015-01-12 10:15:08 PST 
Comment on attachment 244363 [details]
Patch for landing

Clearing flags on attachment: 244363

Committed r178281: <http://trac.webkit.org/changeset/178281>
Comment 7 Alexey Proskuryakov 2015-01-12 11:57:21 PST 
Yes, I'm going to roll out.
Comment 8 Jer Noble 2015-01-12 13:48:55 PST 
Created attachment 244464 [details]
Patch for landing

Replaced two more instances of 'effectivePlaybackRate()' with 'requsetedPlaybackRate()'.
Comment 9 Jer Noble 2015-01-12 14:12:56 PST 
Created attachment 244466 [details]
Patch for landing

Replaced two more instances of 'effectivePlaybackRate()' with 'requsetedPlaybackRate()'.
Comment 10 WebKit Commit Bot 2015-01-13 12:01:44 PST 
Comment on attachment 244466 [details]
Patch for landing

Clearing flags on attachment: 244466

Committed r178367: <http://trac.webkit.org/changeset/178367>