Bug 140272 - Make WKNavigation bridged to API::Navigation
Summary: Make WKNavigation bridged to API::Navigation
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
Depends on: 140294
  Show dependency treegraph
Reported: 2015-01-08 15:21 PST by Sam Weinig
Modified: 2015-01-09 12:10 PST (History)
1 user (show)

See Also:

Patch (26.51 KB, patch)
2015-01-08 15:23 PST, Sam Weinig
no flags Details | Formatted Diff | Diff
Patch (26.53 KB, patch)
2015-01-09 12:07 PST, Sam Weinig
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2015-01-08 15:21:05 PST
Make WKNavigation bridged to API::Navigation
Comment 1 Sam Weinig 2015-01-08 15:23:58 PST
Created attachment 244301 [details]
Comment 2 WebKit Commit Bot 2015-01-08 15:26:44 PST
Attachment 244301 [details] did not pass style-queue:

ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKNavigation.mm:29:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 11 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Sam Weinig 2015-01-08 15:48:31 PST
Committed r178141: <http://trac.webkit.org/changeset/178141>
Comment 4 Alexey Proskuryakov 2015-01-09 09:44:20 PST
This broke multiple API tests, I'm going to roll out.

Comment 5 WebKit Commit Bot 2015-01-09 09:46:32 PST
Re-opened since this is blocked by bug 140294
Comment 6 Sam Weinig 2015-01-09 12:07:41 PST
Created attachment 244361 [details]
Comment 7 Sam Weinig 2015-01-09 12:08:16 PST
New patch fixes the tests by fixing the overreleasing of WKNavigations.
Comment 8 Sam Weinig 2015-01-09 12:10:28 PST
Committed r178185: <http://trac.webkit.org/changeset/178185>