The following layout tests are failing on Windows: userscripts/document-element-available-at-start.html userscripts/mixed-case-stylesheet.html userscripts/script-not-run-for-fragments.html userscripts/script-run-at-end.html userscripts/script-run-at-start.html userscripts/simple-stylesheet.html userscripts/user-script-all-frames.html userscripts/user-script-image-document.html userscripts/user-style-all-frames.html userscripts/user-stylesheet-invalidate.html
These are falling because none of the 'addUserScriptToGroup' or 'removeUserScriptFromGroup' API calls for WebView are connected to anything.
<rdar://problem/19551137>
This requires the following: 1. Duplicate WebCoreGroup from mac->win. (Could almost be shared). 2. Connect the implementations in WebView. Not sure if anyone needs this functionality yet.
Created attachment 255741 [details] Patch
Attachment 255741 [details] did not pass style-queue: ERROR: Source/WebKit/win/WebView.cpp:6460: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/WebView.cpp:6461: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/WebView.cpp:6483: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/WebView.cpp:6484: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/WebView.h:790: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/WebView.h:791: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/WebView.h:794: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/WebView.h:795: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 8 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 255742 [details] Patch
Attachment 255742 [details] did not pass style-queue: ERROR: Source/WebKit/win/WebView.cpp:6460: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/WebView.cpp:6461: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/WebView.cpp:6482: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/WebView.cpp:6483: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/WebView.h:790: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/WebView.h:791: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/WebView.h:794: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/WebView.h:795: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 8 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to comment #7) > Attachment 255742 [details] did not pass style-queue: > > > ERROR: Source/WebKit/win/WebView.cpp:6460: Weird number of spaces at > line-start. Are you using a 4-space indent? [whitespace/indent] [3] > ERROR: Source/WebKit/win/WebView.cpp:6461: Weird number of spaces at > line-start. Are you using a 4-space indent? [whitespace/indent] [3] > ERROR: Source/WebKit/win/WebView.cpp:6482: Weird number of spaces at > line-start. Are you using a 4-space indent? [whitespace/indent] [3] > ERROR: Source/WebKit/win/WebView.cpp:6483: Weird number of spaces at > line-start. Are you using a 4-space indent? [whitespace/indent] [3] > ERROR: Source/WebKit/win/WebView.h:790: Weird number of spaces at > line-start. Are you using a 4-space indent? [whitespace/indent] [3] > ERROR: Source/WebKit/win/WebView.h:791: Weird number of spaces at > line-start. Are you using a 4-space indent? [whitespace/indent] [3] > ERROR: Source/WebKit/win/WebView.h:794: Weird number of spaces at > line-start. Are you using a 4-space indent? [whitespace/indent] [3] > ERROR: Source/WebKit/win/WebView.h:795: Weird number of spaces at > line-start. Are you using a 4-space indent? [whitespace/indent] [3] > Total errors found: 8 in 6 files > > > If any of these errors are false positives, please file a bug against > check-webkit-style. This style errors comes to meet previous parameter's position that looks not meet current webkit style.
I think it'd be better to just skip the tests on Windows than adding more page group level things.
Created attachment 255875 [details] Patch
(In reply to comment #9) > I think it'd be better to just skip the tests on Windows than adding more > page group level things. Done
Attachment 255875 [details] did not pass style-queue: ERROR: Source/WebKit/win/WebView.cpp:6460: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/WebView.cpp:6461: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/WebView.cpp:6482: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/WebView.cpp:6483: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/WebView.h:790: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/WebView.h:791: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/WebView.h:794: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/WebView.h:795: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 8 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to comment #11) > (In reply to comment #9) > > I think it'd be better to just skip the tests on Windows than adding more > > page group level things. > > Done I mean, skip the tests and not implement any WebKit API on Windows :) Unless there's a legitimate need for this on Windows, adding more unused code just for the sake of adding code is a bad idea.
(In reply to comment #13) > (In reply to comment #11) > > (In reply to comment #9) > > > I think it'd be better to just skip the tests on Windows than adding more > > > page group level things. > > > > Done > > I mean, skip the tests and not implement any WebKit API on Windows :) Unless > there's a legitimate need for this on Windows, adding more unused code just > for the sake of adding code is a bad idea. I agreed with you that adding unused code is not good idea. I will hold this patch until we have legitimate needs for Windows port.
Comment on attachment 255875 [details] Patch Removing review flag on this patch so it doesn't show up in the current request queue. Please re-flag for review when we decide we want to pursue this feature.