Bug 140247 – Unfriend StyleResolver and StyleBuilderCustom

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Chris Dumez]

Stop marking StyleBuilderCustom as a friend of StyleResolver by refactoring the code a bit.

[Chris Dumez]

Created attachment 244268 [details]
Patch

[Darin Adler]

Comment on attachment 244268 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=244268&action=review

That turned out really nice.

> Source/WebCore/css/StyleResolver.h:165
> +    Settings* documentSettings() { return m_document.settings(); }

Really annoying that settings can be null. We need to get Kling on the case to help us figure out how to do this. Maybe we can move Settings from Page to MainFrame?

> Source/WebCore/css/StyleResolver.h:-322
> -    Settings* documentSettings() { return m_document.settings(); }

Might need to remove a blank line here to avoid a double black line.

[Chris Dumez]

Comment on attachment 244268 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=244268&action=review

>> Source/WebCore/css/StyleResolver.h:-322
>> -    Settings* documentSettings() { return m_document.settings(); }
> 
> Might need to remove a blank line here to avoid a double black line.

I only see 1 blank line.

[WebKit Commit Bot]

Comment on attachment 244268 [details]
Patch

Clearing flags on attachment: 244268

Committed r178123: <http://trac.webkit.org/changeset/178123>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.