Bug 140237 - Web Inspector: Do not create rulesMap entries for rules without identifiers
Summary: Web Inspector: Do not create rulesMap entries for rules without identifiers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-01-07 19:32 PST by Joseph Pecoraro
Modified: 2015-01-07 20:37 PST (History)
8 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (1.64 KB, patch)
2015-01-07 19:47 PST, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2015-01-07 19:32:01 PST 
* SUMMARY
We are accidentally creating rulesMap entries for rules without identifiers. This was causing a bogus entry in the rulesMap which could cause problems later on.

We started with a null mapKey, which accidentally turns into a string with:

>     mapKey += ":" + occurrence;
Comment 1 Radar WebKit Bug Importer 2015-01-07 19:32:25 PST 
<rdar://problem/19408185>
Comment 2 Joseph Pecoraro 2015-01-07 19:47:25 PST 
Created attachment 244236 [details]
[PATCH] Proposed Fix
Comment 3 WebKit Commit Bot 2015-01-07 20:37:19 PST 
Comment on attachment 244236 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 244236

Committed r178096: <http://trac.webkit.org/changeset/178096>
Comment 4 WebKit Commit Bot 2015-01-07 20:37:22 PST 
All reviewed patches have been landed.  Closing bug.