Bug 140229 - Web Inspector: ObjC Generate types from the GenericTypes domain
Summary: Web Inspector: ObjC Generate types from the GenericTypes domain
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-01-07 16:52 PST by Joseph Pecoraro
Modified: 2015-01-07 17:59 PST (History)
9 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (11.68 KB, patch)
2015-01-07 16:53 PST, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2015-01-07 16:52:01 PST 
* SUMMARY
ObjC Types should generate types from the GenericTypes domain, as they are expected elsewhere.

For example, Page domain expects GenericTypes.SearchMatch:

    @protocol RWIProtocolPageDomainHandler <NSObject>
    - (void)searchInResourceWithErrorCallback:(void(^)(NSString *error))errorCallback successCallback:(void(^)(NSArray/*<RWIProtocolGenericTypesSearchMatch>*/ *result))successCallback...;
    @end
Comment 1 Radar WebKit Bug Importer 2015-01-07 16:52:17 PST 
<rdar://problem/19406637>
Comment 2 Joseph Pecoraro 2015-01-07 16:53:43 PST 
Created attachment 244223 [details]
[PATCH] Proposed Fix
Comment 3 WebKit Commit Bot 2015-01-07 16:55:38 PST 
This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)
Comment 4 WebKit Commit Bot 2015-01-07 17:59:32 PST 
Comment on attachment 244223 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 244223

Committed r178075: <http://trac.webkit.org/changeset/178075>
Comment 5 WebKit Commit Bot 2015-01-07 17:59:35 PST 
All reviewed patches have been landed.  Closing bug.