Bug 140215 – Annotate properties that start with "new" so they'll work under ARC

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Anders Carlsson]

Annotate properties that start with "new" so they'll work under ARC

[Anders Carlsson]

Created attachment 244206 [details]
Patch

[Geoffrey Garen]

Comment on attachment 244206 [details]
Patch

r=me

[Geoffrey Garen]

Does this require an update to some bindings test expectations or a new bindings test?

[Anders Carlsson]

Committed r178057: <http://trac.webkit.org/changeset/178057>

[Darin Adler]

Comment on attachment 244206 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=244206&action=review

> Source/WebCore/bindings/scripts/CodeGeneratorObjC.pm:899
> +                my $needsReturnsRetainedAnnotation = $attributeName =~ /new([A-Z].*)?/;

http://clang.llvm.org/docs/AutomaticReferenceCounting.html#method-families says that we also need to check for alloc, copy, mutableCopy, and new. And maybe even init. I also was considering whether __attribute__((objc_method_family(none))) might not be better than NS_RETURNS_NOT_RETAINED, but I guess not.

Given that documentation, I’m thinking this regular expression should be:

    /_*(alloc|copy|mutableCopy|new)([^a-z].*)?/

That wouldn’t address the init family, but it would cover the copy cases, which I think could easily happen in practice.