Bug 140182 - [Mac] Return multiple ranges for seekable from MediaPlayerPrivateAVFoundation.
Summary: [Mac] Return multiple ranges for seekable from MediaPlayerPrivateAVFoundation.
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-07 10:01 PST by Jer Noble
Modified: 2015-01-08 22:48 PST (History)
7 users (show)

See Also:

Attachments
Patch (15.16 KB, patch)
2015-01-07 10:07 PST, Jer Noble 		eric.carlson: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (14.87 KB, patch)
2015-01-07 10:24 PST, Jer Noble 		buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews105 for mac-mountainlion-wk2 (606.07 KB, application/zip)
2015-01-07 10:41 PST, Build Bot 		no flags Details
Archive of layout-test-results from ews100 for mac-mountainlion (607.18 KB, application/zip)
2015-01-07 10:53 PST, Build Bot 		no flags Details
Archive of layout-test-results from ews106 for mac-mountainlion-wk2 (580.73 KB, application/zip)
2015-01-07 11:16 PST, Build Bot 		no flags Details
Archive of layout-test-results from ews101 for mac-mountainlion (604.61 KB, application/zip)
2015-01-07 11:16 PST, Build Bot 		no flags Details
Patch for landing (14.94 KB, patch)
2015-01-07 13:16 PST, Jer Noble 		buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews105 for mac-mountainlion-wk2 (662.26 KB, application/zip)
2015-01-07 13:43 PST, Build Bot 		no flags Details
Archive of layout-test-results from ews102 for mac-mountainlion (670.73 KB, application/zip)
2015-01-07 14:05 PST, Build Bot 		no flags Details
Patch for landing (15.20 KB, patch)
2015-01-08 14:29 PST, Jer Noble 		commit-queue: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2015-01-07 10:01:00 PST 
[Mac] Return multiple ranges for seekable from MediaPlayerPrivateAVFoundation.
Comment 1 Jer Noble 2015-01-07 10:07:04 PST 
Created attachment 244159 [details]
Patch
Comment 2 Eric Carlson 2015-01-07 10:12:53 PST 
Comment on attachment 244159 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=244159&action=review

> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:890
> +    [m_avPlayer setRate:requestedRate()];
> +

Oops!
Comment 3 Brent Fulgham 2015-01-07 10:14:44 PST 
Comment on attachment 244159 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=244159&action=review

I think this looks good. r=me.

> Source/WebCore/ChangeLog:9
> +        the number of iterations over that array (of one item) in half.

Cool!

> Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:-401
> -        return MediaTime::zeroTime();

Do we not need to handle the case where metadata isn't available anymore? I guess the m_cachedSeekableTimeRanges is nullptr in this case, so we just return an empty PlatformTimeRanges object?
Comment 4 Jer Noble 2015-01-07 10:18:30 PST 
Comment on attachment 244159 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=244159&action=review

>> Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:-401
>> -        return MediaTime::zeroTime();
> 
> Do we not need to handle the case where metadata isn't available anymore? I guess the m_cachedSeekableTimeRanges is nullptr in this case, so we just return an empty PlatformTimeRanges object?

Yep, that's the idea.

>> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:890
>> +
> 
> Oops!

Oops indeed! Part of another patch.
Comment 5 Jer Noble 2015-01-07 10:24:09 PST 
Created attachment 244162 [details]
Patch for landing
Comment 6 Build Bot 2015-01-07 10:41:41 PST 
Comment on attachment 244159 [details]
Patch

Attachment 244159 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5172514837757952

Number of test failures exceeded the failure limit.
Comment 7 Build Bot 2015-01-07 10:41:44 PST 
Created attachment 244164 [details]
Archive of layout-test-results from ews105 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 8 Build Bot 2015-01-07 10:53:31 PST 
Comment on attachment 244159 [details]
Patch

Attachment 244159 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6518873268420608

Number of test failures exceeded the failure limit.
Comment 9 Build Bot 2015-01-07 10:53:34 PST 
Created attachment 244166 [details]
Archive of layout-test-results from ews100 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 10 Build Bot 2015-01-07 11:16:22 PST 
Comment on attachment 244162 [details]
Patch for landing

Attachment 244162 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/4884825580240896

Number of test failures exceeded the failure limit.
Comment 11 Build Bot 2015-01-07 11:16:25 PST 
Created attachment 244168 [details]
Archive of layout-test-results from ews106 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 12 Build Bot 2015-01-07 11:16:30 PST 
Comment on attachment 244162 [details]
Patch for landing

Attachment 244162 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5379656815476736

Number of test failures exceeded the failure limit.
Comment 13 Build Bot 2015-01-07 11:16:33 PST 
Created attachment 244169 [details]
Archive of layout-test-results from ews101 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 14 Jer Noble 2015-01-07 13:16:06 PST 
Created attachment 244183 [details]
Patch for landing
Comment 15 Build Bot 2015-01-07 13:43:22 PST 
Comment on attachment 244183 [details]
Patch for landing

Attachment 244183 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5184468134395904

Number of test failures exceeded the failure limit.
Comment 16 Build Bot 2015-01-07 13:43:25 PST 
Created attachment 244187 [details]
Archive of layout-test-results from ews105 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 17 Build Bot 2015-01-07 14:05:18 PST 
Comment on attachment 244183 [details]
Patch for landing

Attachment 244183 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5491794519261184

Number of test failures exceeded the failure limit.
Comment 18 Build Bot 2015-01-07 14:05:23 PST 
Created attachment 244198 [details]
Archive of layout-test-results from ews102 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 19 Jer Noble 2015-01-08 14:29:52 PST 
Created attachment 244294 [details]
Patch for landing
Comment 20 WebKit Commit Bot 2015-01-08 22:48:30 PST 
Comment on attachment 244294 [details]
Patch for landing

Rejecting attachment 244294 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 244294, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.appspot.com/results/4797709147963392