Bug 140170 - Make webkit-patch try harder to find keychain credentials
Summary: Make webkit-patch try harder to find keychain credentials
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-06 20:22 PST by Myles C. Maxfield
Modified: 2015-01-07 13:20 PST (History)
5 users (show)

See Also:

Attachments
Patch (4.04 KB, patch)
2015-01-06 20:26 PST, Myles C. Maxfield 		rniwa: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2015-01-06 20:22:51 PST 
Make webkit-patch try harder to find keychain credentials
Comment 1 Myles C. Maxfield 2015-01-06 20:26:21 PST 
Created attachment 244133 [details]
Patch
Comment 2 Ryosuke Niwa 2015-01-06 22:05:36 PST 
Comment on attachment 244133 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=244133&action=review

> Tools/Scripts/webkitpy/common/net/credentials.py:121
> +            if parsed_output[0] or parsed_output[1]:

Why not any(parsed_output)?
Comment 3 Myles C. Maxfield 2015-01-07 13:20:58 PST 
Committed r178049: <http://trac.webkit.org/changeset/178049>