Bug 140160 - [WK2] Start a prototype for declarative site specific extensions
Summary: [WK2] Start a prototype for declarative site specific extensions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-06 17:57 PST by Benjamin Poulain
Modified: 2015-01-08 17:55 PST (History)
6 users (show)

See Also:

Attachments
Patch (94.37 KB, patch)
2015-01-06 18:38 PST, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
Patch (94.32 KB, patch)
2015-01-06 19:13 PST, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
Patch (94.29 KB, patch)
2015-01-06 21:01 PST, Benjamin Poulain 		kling: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2015-01-06 17:57:03 PST 
[WK2] Start a prototype for declarative site specific extensions
Comment 1 Benjamin Poulain 2015-01-06 18:38:42 PST 
Created attachment 244116 [details]
Patch
Comment 2 Benjamin Poulain 2015-01-06 19:13:36 PST 
Created attachment 244123 [details]
Patch
Comment 3 Benjamin Poulain 2015-01-06 21:01:37 PST 
Created attachment 244136 [details]
Patch
Comment 4 Benjamin Poulain 2015-01-07 12:47:51 PST 
Comment on attachment 244136 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=244136&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKProcessPoolPrivate.h:46
> +- (void)_loadContentExtensionWithIdentifier:(NSString *)identifier serializedRules:(NSString *)serializedRules successCompletionHandler:(void (^)(NSDictionary *info))successCompletionHandler errorCompletionHandler:(void (^)(NSError *error))errorCompletionHandler;

Add
FIXME: move the API to a better place.
Comment 5 Andreas Kling 2015-01-08 17:01:30 PST 
Comment on attachment 244136 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=244136&action=review

r=me. This seems like a good-enough foundation to build on.

> Source/WebCore/contentextensions/DFA.cpp:43
> +    : m_nodes(nodes)

I think this needs to explicitly move or it will be a copy:
: m_nodes(WTF::move(nodes))

> Source/WebCore/contentextensions/DFA.h:51
> +    Vector<uint64_t> actions(unsigned currentState) const;

This is returning a copy of the Vector, which is probably not what you want.
Comment 6 Benjamin Poulain 2015-01-08 17:55:57 PST 
Committed r178151: <http://trac.webkit.org/changeset/178151>