Bug 140153 - Allow MathML in dashboard compatibility mode
Summary: Allow MathML in dashboard compatibility mode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks: 183562
  Show dependency treegraph
 
Reported: 2015-01-06 15:59 PST by Sam Weinig
Modified: 2018-03-12 04:25 PDT (History)
9 users (show)

See Also:


Attachments
Patch (3.88 KB, patch)
2015-01-06 16:11 PST, Sam Weinig
ap: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2015-01-06 15:59:00 PST
Allow MathML in dashboard compatability mode
Comment 1 Sam Weinig 2015-01-06 16:11:08 PST
Created attachment 244106 [details]
Patch
Comment 2 Alexey Proskuryakov 2015-01-06 16:17:37 PST
Comment on attachment 244106 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=244106&action=review

> LayoutTests/ChangeLog:8
> +        * mathml/mathml-in-dashboard-expected.txt: Added.

But where is -expected.png?
Comment 3 Sam Weinig 2015-01-06 16:34:17 PST
Committed r178006: <http://trac.webkit.org/changeset/178006>
Comment 4 Simon Fraser (smfr) 2015-01-06 20:52:10 PST
The test is failing with:
CONSOLE MESSAGE: line 3: TypeError: undefined is not a function (evaluating 'testRunner.setUseDashboardCompatibilityMode(true)')

https://build.webkit.org/results/Apple%20Mavericks%20Debug%20WK2%20(Tests)/r178014%20(8758)/results.html

Maybe I should roll this out?
Comment 5 Alexey Proskuryakov 2015-01-06 23:13:51 PST
You probably should have, but I will skip the test on WebKit2 instead :)
Comment 6 Frédéric Wang (:fredw) 2018-03-09 10:09:44 PST
I just landed https://trac.webkit.org/changeset/229463/webkit to skip the test on GTK and remove the expectations.

@Brent, Per: Should we do the same for Windows?