Only throttle DOM timers if they change CSS properties that cannot cause non-descendant elements to become visible

[Chris Dumez]

Only throttle DOM timers if they change CSS properties that cannot cause non-descendant elements to become visible. For example, a DOM timer may change the height of an element that is outside the viewport. However, changing its height may causes elements inside the viewport to move. As such, we should NOT throttle such DOM timer.

[Chris Dumez]

Created attachment 244093 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 244093 [details]
Patch

Clearing flags on attachment: 244093

Committed r178014: <http://trac.webkit.org/changeset/178014>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Daniel Bates]

Comment on attachment 244093 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=244093&action=review

> LayoutTests/fast/dom/timer-height-change-no-throttling.html:31
> +    setTimeout(scrollElementIntoView, 0);

Did you mean to include this line? If so, scrollElementIntoView needs to be defined.

[Chris Dumez]

Comment on attachment 244093 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=244093&action=review

>> LayoutTests/fast/dom/timer-height-change-no-throttling.html:31
>> +    setTimeout(scrollElementIntoView, 0);
> 
> Did you mean to include this line? If so, scrollElementIntoView needs to be defined.

No, this line needs to go away.

[Chris Dumez]

Reopening to attach new patch.

[Chris Dumez]

Created attachment 244563 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 244563 [details]
Patch

Clearing flags on attachment: 244563

Committed r178403: <http://trac.webkit.org/changeset/178403>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.