RESOLVED FIXED 140101
[TexMap]TextureMapperLayer - avoiding multiple regions in paintUsingOverlapRegions 
https://bugs.webkit.org/show_bug.cgi?id=140101
Summary [TexMap]TextureMapperLayer - avoiding multiple regions in paintUsingOverlapRe...
abaldeva
Reported 2015-01-05 15:13:09 PST
Created attachment 244009 [details] 1 pixel offset overlapping region Hi, In TextureMapperLayer::paintUsingOverlapRegions, there is a check to avoid dividing the area between overlapping and nonoverlapping. The current check is if (overlapRegion.bounds().size().area() > nonOverlapRegion.bounds().size().area()) However, I think it is incorrect. If the overlap region is just 1 pixel small from all the 4 side, this check would not catch that. Attached an html that reproduces the issue. Seems to me that the correct check should be if (overlapRegion.totalArea() > nonOverlapRegion.totalArea) Thoughts? Arpit
Attachments
1 pixel offset overlapping region (351 bytes, text/html)
2015-01-05 15:13 PST, abaldeva 		no flags
Details
Patch (1.70 KB, patch)
2022-06-09 19:23 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Patch (2.54 KB, patch)
2022-06-13 14:30 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2020-10-12 14:36:02 PDT
The code was added by r149369 (Bug 115226).
Fujii Hironori
Comment 2 2022-06-09 19:05:19 PDT
(In reply to abaldeva from comment #0) > Seems to me that the correct check should be > if (overlapRegion.totalArea() > nonOverlapRegion.totalArea) > > Thoughts? It sounds like a good idea to me. Will prepare a patch.
Fujii Hironori
Comment 3 2022-06-09 19:23:01 PDT
Created attachment 460152 [details] Patch
Fujii Hironori
Comment 4 2022-06-13 14:18:17 PDT
gtk-wk2 EWS reports a test failure. imported/w3c/web-platform-tests/css/css-transforms/transform3d-rotatex-perspective-003.html [ ImageOnlyFailure ] This is a true-positive. Created bug#241568 for it.
Fujii Hironori
Comment 5 2022-06-13 14:30:59 PDT
Created attachment 460215 [details] Patch
EWS
Comment 6 2022-06-14 15:22:49 PDT
Committed r295542 (251547@main): <https://commits.webkit.org/251547@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 460215 [details].
Radar WebKit Bug Importer
Comment 7 2022-06-14 15:23:13 PDT
<rdar://problem/95148331>
Note You need to log in before you can comment on or make changes to this bug.