Bug 140099 - Purge PassRefPtr from SharedBuffer.
Summary: Purge PassRefPtr from SharedBuffer.
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-05 14:38 PST by Andreas Kling
Modified: 2022-09-17 17:03 PDT (History)
4 users (show)

See Also:

Attachments
Patch (37.50 KB, patch)
2015-01-05 17:24 PST, Andreas Kling 		buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews103 for mac-mountainlion (574.52 KB, application/zip)
2015-01-05 17:53 PST, Build Bot 		no flags Details
Archive of layout-test-results from ews105 for mac-mountainlion-wk2 (513.48 KB, application/zip)
2015-01-05 17:59 PST, Build Bot 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2015-01-05 14:38:34 PST 
Purge PassRefPtr from SharedBuffer.
Comment 1 Andreas Kling 2015-01-05 17:24:18 PST 
Created attachment 244020 [details]
Patch
Comment 2 WebKit Commit Bot 2015-01-05 17:26:43 PST 
Attachment 244020 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/SharedBuffer.h:61:  The parameter name "vector" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/SharedBuffer.h:67:  The parameter name "data" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 28 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Build Bot 2015-01-05 17:53:22 PST 
Comment on attachment 244020 [details]
Patch

Attachment 244020 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6200193540161536

New failing tests:
http/tests/appcache/offline-access.html
Comment 4 Build Bot 2015-01-05 17:53:24 PST 
Created attachment 244024 [details]
Archive of layout-test-results from ews103 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 5 Build Bot 2015-01-05 17:59:31 PST 
Comment on attachment 244020 [details]
Patch

Attachment 244020 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6550374706053120

New failing tests:
http/tests/appcache/offline-access.html
Comment 6 Build Bot 2015-01-05 17:59:33 PST 
Created attachment 244025 [details]
Archive of layout-test-results from ews105 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 7 Ahmad Saleem 2022-09-17 17:03:06 PDT 
PassRefPtr usage does not exist anymore in Webkit GitHub as of today. So I am marking this as "RESOLVED WONTFIX". Thanks!