Bug 140098 - REGRESSION(r177925): It broke the !ENABLE(INSPECTOR) build
Summary: REGRESSION(r177925): It broke the !ENABLE(INSPECTOR) build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P1 Blocker
Assignee: Csaba Osztrogonác
URL:
Keywords:
Depends on:
Blocks: 139981
  Show dependency tree / graph
 
Reported: 2015-01-05 14:09 PST by Csaba Osztrogonác
Modified: 2015-01-09 11:27 PST (History)
5 users (show)

See Also:

Attachments
Patch (5.52 KB, patch)
2015-01-09 07:55 PST, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
Patch (4.36 KB, patch)
2015-01-09 08:30 PST, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2015-01-05 14:09:02 PST 
error log:
In file included from ../../Source/WebCore/page/ContentSecurityPolicy.cpp:35:0:
../../Source/WebCore/inspector/InspectorInstrumentation.h:144:12: error: 'InspectorInstrumentationCookie' does not name a type
../../Source/WebCore/inspector/InspectorInstrumentation.h:145:39: error: 'InspectorInstrumentationCookie' does not name a type
../../Source/WebCore/inspector/InspectorInstrumentation.h:145:69: error: ISO C++ forbids declaration of 'parameter' with no type [-fpermissive]
../../Source/WebCore/inspector/InspectorInstrumentation.h:146:12: error: 'InspectorInstrumentationCookie' does not name a type
../../Source/WebCore/inspector/InspectorInstrumentation.h:147:59: error: 'InspectorInstrumentationCookie' does not name a type

...
Comment 1 Csaba Osztrogonác 2015-01-09 07:55:10 PST 
Created attachment 244341 [details]
Patch
Comment 2 Brian Burg 2015-01-09 07:58:25 PST 
Comment on attachment 244341 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=244341&action=review

> Source/WebCore/loader/appcache/ApplicationCacheGroup.cpp:582
> +#endif

It is my understanding that all callsites into InspectorInstrumentation should not be guarded, since they are defined even if !ENABLE(INSPECTOR) and there are ENABLE(INSPECTOR) guards inside those methods. Is this file missing an #include or something to make it not compile? I would prefer to not have guards here.
Comment 3 Csaba Osztrogonác 2015-01-09 08:26:34 PST 
m_currentResourceIdentifier is inside ENABLE(INSPECTOR) guard
which caused build failure in ApplicationCacheGroup.cpp.

Unguarding fixes the build without changing the cpp.
Comment 4 Csaba Osztrogonác 2015-01-09 08:30:09 PST 
Created attachment 244344 [details]
Patch
Comment 5 Csaba Osztrogonác 2015-01-09 08:40:54 PST 
Just a note, there were a discussion on IRC if !INSPECTOR build is useful or not.

I checked the stripped binary size of the EFL WebKit library on x86_64.
Disabling inspector decreases the original 43Mb with 1.2Mb, circa 2.8%.
Comment 6 Brian Burg 2015-01-09 10:45:35 PST 
Comment on attachment 244344 [details]
Patch

Thanks!
Comment 7 WebKit Commit Bot 2015-01-09 11:27:55 PST 
Comment on attachment 244344 [details]
Patch

Clearing flags on attachment: 244344

Committed r178177: <http://trac.webkit.org/changeset/178177>
Comment 8 WebKit Commit Bot 2015-01-09 11:27:58 PST 
All reviewed patches have been landed.  Closing bug.