Modernize the HTMLElement factory
Created attachment 243955 [details] Patch
Attachment 243955 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:11: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] Total errors found: 1 in 144 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 243955 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=243955&action=review > Source/WebCore/dom/make_names.pl:384 > + my $smartPointerType = ($parameters{namespace} eq "HTML") ? "Ref" : "PassRefPtr"; I’d rather you listed the legacy namespaces that still need PassRefPtr and made HTML the normal one.
(In reply to comment #3) > Comment on attachment 243955 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=243955&action=review > > > Source/WebCore/dom/make_names.pl:384 > > + my $smartPointerType = ($parameters{namespace} eq "HTML") ? "Ref" : "PassRefPtr"; > > I’d rather you listed the legacy namespaces that still need PassRefPtr and > made HTML the normal one. Good idea.
Created attachment 243964 [details] Patch
Attachment 243964 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:11: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] Total errors found: 1 in 146 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 243964 [details] Patch Seems like later we should make the generator smart, and have it only pass the tagName if the same class is used for more than one tag. Then we can get rid of many extra create functions.
Comment on attachment 243964 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=243964&action=review > Source/WebCore/ChangeLog:11 > + * Files elided * I wouldn’t have done that (by the way), but I guess it’s OK.
Comment on attachment 243964 [details] Patch Rejecting attachment 243964 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 243964, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: /html/HTMLUnknownElement.h patching file Source/WebCore/html/HTMLVideoElement.cpp patching file Source/WebCore/html/HTMLVideoElement.h patching file Source/WebCore/html/HTMLWBRElement.cpp patching file Source/WebCore/html/HTMLWBRElement.h patching file Source/WebCore/mathml/MathMLElement.cpp patching file Source/WebCore/mathml/MathMLElement.h Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Darin Adler']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/6306838249209856
Committed r177996: <http://trac.webkit.org/changeset/177996>