Bug 140030 - ASSERT that a null key is never used with FeatureCounter
Summary: ASSERT that a null key is never used with FeatureCounter
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-01 13:29 PST by Chris Dumez
Modified: 2015-01-01 15:53 PST (History)
4 users (show)

See Also:

Attachments
Patch (2.32 KB, patch)
2015-01-01 13:31 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (2.23 KB, patch)
2015-01-01 14:09 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (2.33 KB, patch)
2015-01-01 15:12 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2015-01-01 13:29:30 PST 
ASSERT that a null key is never used with FeatureCounter
Comment 1 Chris Dumez 2015-01-01 13:31:34 PST 
Created attachment 243869 [details]
Patch
Comment 2 Chris Dumez 2015-01-01 14:09:10 PST 
Created attachment 243871 [details]
Patch
Comment 3 Darin Adler 2015-01-01 15:07:01 PST 
Comment on attachment 243871 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=243871&action=review

> Source/WebCore/platform/FeatureCounter.cpp:55
> +    ASSERT_ARG(key, key);

Release builds will give a warning unless you use ASSERT_UNUSED here.

> Source/WebCore/platform/FeatureCounter.cpp:61
> +    ASSERT_ARG(key, key);

Release builds will give a warning unless you use ASSERT_UNUSED here.
Comment 4 Chris Dumez 2015-01-01 15:12:00 PST 
Created attachment 243873 [details]
Patch
Comment 5 WebKit Commit Bot 2015-01-01 15:53:20 PST 
Comment on attachment 243873 [details]
Patch

Clearing flags on attachment: 243873

Committed r177851: <http://trac.webkit.org/changeset/177851>
Comment 6 WebKit Commit Bot 2015-01-01 15:53:25 PST 
All reviewed patches have been landed.  Closing bug.