RESOLVED FIXED 140017
Remove the remaining uses of OwnPtr from WebKit2 
https://bugs.webkit.org/show_bug.cgi?id=140017
Summary Remove the remaining uses of OwnPtr from WebKit2
Sam Weinig
Reported 2014-12-31 10:28:07 PST
Remove the remaining uses of OwnPtr from WebKit2
Attachments
Patch (22.95 KB, patch)
2014-12-31 10:56 PST, Sam Weinig 		mitz: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2014-12-31 10:56:12 PST
Created attachment 243850 [details] Patch
Sam Weinig
Comment 2 2014-12-31 12:01:01 PST
Committed r177835: <http://trac.webkit.org/changeset/177835>
Csaba Osztrogonác
Comment 3 2014-12-31 17:04:44 PST
(In reply to comment #2) > Committed r177835: <http://trac.webkit.org/changeset/177835> It broke the EFL build, as the EWS noticed it before landing and the buildbots noticed after landing: ../../Source/WebCore/page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.cpp: In constructor ‘WebCore::ScrollingCoordinatorCoordinatedGraphics::ScrollingCoordinatorCoordinatedGraphics(WebCore::Page*)’: ../../Source/WebCore/page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.cpp:49:28: error: ‘create’ is not a member of ‘WebCore::ScrollingStateTree’ , m_scrollingStateTree(ScrollingStateTree::create()) ^ ninja: build stopped: subcommand failed.
Csaba Osztrogonác
Comment 4 2014-12-31 17:05:27 PST
buildfix landed in https://trac.webkit.org/changeset/177840
Csaba Osztrogonác
Comment 5 2014-12-31 17:08:21 PST
Just out of curiosity: Is there a new policy about Apple is allowed to break other builds intentionally outside WebKit2 in the new year? I probably missed the announce about it on webkit-dev ...
Sam Weinig
Comment 6 2014-12-31 17:54:24 PST
(In reply to comment #5) > Just out of curiosity: Is there a new policy about Apple is allowed > to break other builds intentionally outside WebKit2 in the new year? > > I probably missed the announce about it on webkit-dev ... Nope. I just didn't botice I broke it. Ping me next time and I will fix it right away.
Note You need to log in before you can comment on or make changes to this bug.