Revision r177795 <http://trac.webkit.org/r177795> has broken the GTK build: Build log: https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Build%29/builds/54028/steps/compile-webkit/logs/stdio
Created attachment 243823 [details] Patch
Comment on attachment 243823 [details] Patch I'm not exactly sure why and how the build error popped up now, but the GTK-specific argument coders were simply not included (anymore?) in the WebPageProxyMessageReceiver.cpp file. This should fix it for good, but I want a review to asses whether it might not be an appropriate approach.
Comment on attachment 243823 [details] Patch Seems probably not the right approach. ArgumentCodersCF.h and ArgumentCodersMac.h don’t work this way.
Comment on attachment 243823 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=243823&action=review Why not simply including ArgumentCodersGtk.h from the sources which need it? Or including it from only ArgumentCoders.h and adding a guard to avoid including it from anywhere else. > Source/WebKit2/Platform/IPC/ArgumentCoders.h:305 > +#if PLATFORM(GTK) > +#include "ArgumentCodersGtk.h" > +#endif ArgumentCoders.h is included in ArgumentCodersGtk.h too.
(In reply to comment #4) > Why not simply including ArgumentCodersGtk.h from the sources which need it? Ah, WebPageProxyMessageReceiver.cpp is a generated source, so it isn't so easy to fix the generator properly.
(In reply to comment #2) > Comment on attachment 243823 [details] > Patch > > I'm not exactly sure why and how the build error popped up now, but the > GTK-specific argument coders were simply not included (anymore?) in the > WebPageProxyMessageReceiver.cpp file. This should fix it for good, but I > want a review to asses whether it might not be an appropriate approach. I found the root of the problem. Before r177795 ArgumentCodersGtk.h was included indirectly: InjectedBundleUserMessageCoders.h -> WebPage.h -> ArgumentCodersGtk.h. But now InjectedBundleUserMessageCoders.h isn't included anymore.
Committed a fix in r177832. http://trac.webkit.org/changeset/177832 I just moved the ArgumentCodersGtk.h inclusion from WebPageProxy.cpp to WebPageProxy.h, which makes ArgumentCoder<WebCore::DragData> available in WebPageProxyMessageReceiver.cpp.