Bug 139987 – Move Pasteboard code out of WebProcessPool and into its own singleton class

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Sam Weinig]

Move Pasteboard code out of WebProcessPool and into its own singleton class

[Sam Weinig]

Created attachment 243797 [details]
Patch

[Anders Carlsson]

Comment on attachment 243797 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=243797&action=review

> Source/WebKit2/Shared/WebPasteboardProxy.cpp:40
> +    static WebPasteboardProxy* proxy;
> +    static dispatch_once_t once;
> +    dispatch_once(&once, ^{
> +        proxy = new WebPasteboardProxy;
> +    });

You can use LazyNeverDestroyed here.

> Source/WebKit2/Shared/WebPasteboardProxy.messages.in:57
> +#if !PLATFORM(COCOA)
> +    // FIXME: This a dummy message, to avoid breaking the build for platforms that don't require
> +    // any synchronous messages, and should be removed when <rdar://problem/8775115> is fixed.
> +    Dummy() -> (bool dummyReturn)
> +#endif

I don't think this is needed.

> Source/WebKit2/UIProcess/WebProcessPool.cpp:-1169
> -    if (decoder.messageReceiverName() == Messages::WebProcessPool::messageReceiverName()) {
> -        didReceiveSyncWebProcessPoolMessage(connection, decoder, replyEncoder);
> -        return;
> -    }

I think we stil need this for now since I moved the message handling code to WebProcessPool.

[Sam Weinig]

Created attachment 243799 [details]
Patch

[Sam Weinig]

Committed r177794: <http://trac.webkit.org/changeset/177794>