There is missing a null pointer check in the UniscribeController::shape() method. I have gotten several crashes here because the font data pointer was null.
Created attachment 243779 [details] Patch
Comment on attachment 243779 [details] Patch Test case?
(In reply to comment #2) > Comment on attachment 243779 [details] > Patch > > Test case? test for wincairo? :) It's impossible to run any layout test on wincairo. (N)RWT doesn't know wincairo port (bug124927) and there isn't ORWT long time ago ...
(In reply to comment #3) > (In reply to comment #2) > > Comment on attachment 243779 [details] > > Patch > > > > Test case? > > test for wincairo? :) > > It's impossible to run any layout test on wincairo. (N)RWT doesn't > know wincairo port (bug124927) and there isn't ORWT long time ago ... So, is it time to remove support for WinCairo? A port without any testing seems like a bad idea. Do you at least have a test case that crashes in a WinCairo mini browser?
I think we should not need both an assert and a null check. Asserts should be for things that should never be false. Sam, I have hardware for a WinCairo bot. See https://bugs.webkit.org/show_bug.cgi?id=139908 The few differences between AppleWin and WinCairo are tested manually and that has worked well for some time now.
And layout tests can be run with WinCairo, it just requires a bit of impersonating AppleWin right now.
(In reply to comment #2) > Comment on attachment 243779 [details] > Patch > > Test case? I will try to come up with a test case :)
Here is a somewhat reduced test case which crashes the browser every time: <html> <head> <style> span.texhtml{font-family:"Nimbus Roman No9 L","Times New Roman",Times,serif;font-size:118%;line-height:1} .texhtml{-webkit-font-feature-settings:"lnum","tnum";font-feature-settings:"lnum","tnum"} </style> </head> <body> <span class="texhtml">|<span class="Unicode">⟩</span></span> </body> </html>
Comment on attachment 243779 [details] Patch I assume this change fixes it so it doesn't crash. Then add the test to layout tests and upload a new patch.
Created attachment 243917 [details] Patch
(In reply to comment #9) > Comment on attachment 243779 [details] > Patch > > I assume this change fixes it so it doesn't crash. Then add the test to > layout tests and upload a new patch. Thanks for reviewing :) Updated patch.
Comment on attachment 243917 [details] Patch Clearing flags on attachment: 243917 Committed r177909: <http://trac.webkit.org/changeset/177909>
All reviewed patches have been landed. Closing bug.