Bug 139964 - [Cocoa] WKWebProcessPlugInLoadDelegate uses the deprecated WKRenderingProgressEvents enum
Summary: [Cocoa] WKWebProcessPlugInLoadDelegate uses the deprecated WKRenderingProgres...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: mitz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-26 21:21 PST by mitz
Modified: 2014-12-27 10:15 PST (History)
3 users (show)

See Also:


Attachments
Use _WKRenderingProgressEvents (27.38 KB, patch)
2014-12-26 21:32 PST, mitz
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2014-12-26 21:21:43 PST
-webProcessPlugInBrowserContextController:renderingProgressDidChange: should take a _WKRenderingProgressEvents, not WKRenderingProgressEvents. The latter is deprecated and could be removed soon.
Comment 1 mitz 2014-12-26 21:32:35 PST
Created attachment 243774 [details]
Use _WKRenderingProgressEvents
Comment 2 WebKit Commit Bot 2014-12-26 21:34:26 PST
Attachment 243774 [details] did not pass style-queue:


ERROR: Source/WebKit2/Shared/API/Cocoa/_WKRenderingProgressEvents.h:30:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 mitz 2014-12-27 10:15:00 PST
Fixed in <http://trac.webkit.org/r177760>.