Bug 139963 - Disable W3C test harness timeout
Summary: Disable W3C test harness timeout
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-26 19:51 PST by Alexey Proskuryakov
Modified: 2014-12-28 10:51 PST (History)
2 users (show)

See Also:

Attachments
proposed patch (2.23 KB, patch)
2014-12-26 19:53 PST, Alexey Proskuryakov 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2014-12-26 19:51:12 PST 
W3C test harness has "normal" and "long" timeouts, and tests can choose which to use. But there is no way to make these conditional on build style, and the built-in values are inappropriate for some debug builds, such as leaks bots or ASan/GuardMalloc.

Perhaps we can simply disable the built-in timeouts, and let run-webkit-tests/DumpRenderTree/WebKitTestRunner work normally.
Comment 1 Alexey Proskuryakov 2014-12-26 19:53:21 PST 
Created attachment 243772 [details]
proposed patch
Comment 2 WebKit Commit Bot 2014-12-27 14:33:39 PST 
Comment on attachment 243772 [details]
proposed patch

Clearing flags on attachment: 243772

Committed r177770: <http://trac.webkit.org/changeset/177770>
Comment 3 WebKit Commit Bot 2014-12-27 14:33:42 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 Myles C. Maxfield 2014-12-27 19:25:58 PST 
This seems to have caused media failures. See https://build.webkit.org/results/Apple%20Yosemite%20Debug%20WK2%20(Tests)/r177770%20(1158)/results.html
Comment 5 Alexey Proskuryakov 2014-12-28 00:25:53 PST 
Ugh. Perhaps some tests had failure expectations, and time out now?

build.webkit.org fails to load at the moment.
Comment 6 Alexey Proskuryakov 2014-12-28 10:51:58 PST 
Two tests had error output with line numbers, and line numbers changed. Updated in r177780.