Bug 139958 – fast/canvas/webgl/angle-instanced-arrays.html is very flaky

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Alexey Proskuryakov]

fast/canvas/webgl/angle-instanced-arrays.html frequently fails, dumping TEST COMPLETE twice:

@@ -81,4 +81,7 @@
 PASS successfullyParsed is true
 
 TEST COMPLETE
+PASS successfullyParsed is true
 
+TEST COMPLETE
+

This is a problem with both the test and test framework. They way js-test-post.js is inserted is incorrect, because it is affected by how quickly test document loads.

[Alexey Proskuryakov]

Created attachment 243766 [details]
proposed fix

This cleans up test harness usage in all fast/canvas/webgl.

We also have many of the same tests as part of WebGL 1.0.x test suites, and looks like they often have the same issues. I'm not sure if there is a script that imports these, if so, it should be probably updated to use these techniques. Otherwise, this cleanup could serve as an example for how these other copies should be updated.

[Build Bot]

Comment on attachment 243766 [details]
proposed fix

Attachment 243766 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5868542205362176

New failing tests:
svg/custom/html_document_set_title.html
fast/dom/HTMLImageElement/sizes/image-sizes-js-innerhtml.html
fast/dom/HTMLImageElement/sizes/image-sizes-2x.html
fast/dom/HTMLImageElement/sizes/image-sizes-1x.html
fast/hidpi/image-srcset-src-selection-1x-both.html
fast/hidpi/image-srcset-invalid-descriptor.html

[Build Bot]

Created attachment 243768 [details]
Archive of layout-test-results from ews106 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Alexey Proskuryakov]

Created attachment 243769 [details]
proposed fix

Nice, so several other tests that use js-test.js have nicer output now.

[WebKit Commit Bot]

Comment on attachment 243769 [details]
proposed fix

Rejecting attachment 243769 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 243769, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
nch master is up to date.
Auto packing the repository for optimum performance. You may also
run "git gc" manually. See "git help gc" for more information.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.


Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit
Updating OpenSource
Current branch master is up to date.

Full output: http://webkit-queues.appspot.com/results/6122017216528384

[WebKit Commit Bot]

Comment on attachment 243769 [details]
proposed fix

Clearing flags on attachment: 243769

Committed r177772: <http://trac.webkit.org/changeset/177772>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.