Bug 139948 - Fix build warning after r177700
Summary: Fix build warning after r177700
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hunseop Jeong
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-25 17:29 PST by Hunseop Jeong
Modified: 2014-12-25 19:52 PST (History)
5 users (show)

See Also:

Attachments
Patch (1.55 KB, patch)
2014-12-25 17:32 PST, Hunseop Jeong 		no flags Details | Formatted Diff | Diff
Patch (1.55 KB, patch)
2014-12-25 17:35 PST, Hunseop Jeong 		no flags Details | Formatted Diff | Diff
Patch (1.67 KB, patch)
2014-12-25 18:15 PST, Hunseop Jeong 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hunseop Jeong 2014-12-25 17:29:27 PST 
../../Source/WebKit2/UIProcess/WebConnectionToWebProcess.cpp:53:21: warning: unused parameter ‘object’ [-Wunused-parameter]
 RefPtr<API::Object> WebConnectionToWebProcess::transformHandlesToObjects(API::Object* object)
                     ^
../../Source/WebKit2/UIProcess/WebConnectionToWebProcess.cpp:60:21: warning: unused parameter ‘object’ [-Wunused-parameter]
 RefPtr<API::Object> WebConnectionToWebProcess::transformObjectsToHandles(API::Object* object)
Comment 1 Hunseop Jeong 2014-12-25 17:32:34 PST 
Created attachment 243751 [details]
Patch
Comment 2 Hunseop Jeong 2014-12-25 17:35:35 PST 
Created attachment 243752 [details]
Patch
Comment 3 Gyuyoung Kim 2014-12-25 18:01:13 PST 
Comment on attachment 243752 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=243752&action=review

> Source/WebKit2/ChangeLog:3
> +        Unreviewed, fix build warning after r177700

Build warning should be reviewed. And also it would be good to get a review from WK2 owner.

> Source/WebKit2/UIProcess/WebConnectionToWebProcess.cpp:53
>  RefPtr<API::Object> WebConnectionToWebProcess::transformHandlesToObjects(API::Object* object)

In this case, I would recommend to remove object parameter here instead of UNUSED_PARAM().

> Source/WebKit2/UIProcess/WebConnectionToWebProcess.cpp:63
> +    UNUSED_PARAM(object);

ditto.
Comment 4 Hunseop Jeong 2014-12-25 18:13:11 PST 
(In reply to comment #3)
> Comment on attachment 243752 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=243752&action=review
> 
> > Source/WebKit2/ChangeLog:3
> > +        Unreviewed, fix build warning after r177700
> 
> Build warning should be reviewed. And also it would be good to get a review
> from WK2 owner.
> 

Okay, I try to get a review from WK2 owner.

> > Source/WebKit2/UIProcess/WebConnectionToWebProcess.cpp:53
> >  RefPtr<API::Object> WebConnectionToWebProcess::transformHandlesToObjects(API::Object* object)
> 
> In this case, I would recommend to remove object parameter here instead of
> UNUSED_PARAM().
> 
> > Source/WebKit2/UIProcess/WebConnectionToWebProcess.cpp:63
> > +    UNUSED_PARAM(object);
> 
> ditto.

I removed the parameter instead of UNUSED_PARAM(). Thanks,
Comment 5 Hunseop Jeong 2014-12-25 18:15:50 PST 
Created attachment 243753 [details]
Patch
Comment 6 WebKit Commit Bot 2014-12-25 19:52:00 PST 
Comment on attachment 243753 [details]
Patch

Clearing flags on attachment: 243753

Committed r177743: <http://trac.webkit.org/changeset/177743>
Comment 7 WebKit Commit Bot 2014-12-25 19:52:05 PST 
All reviewed patches have been landed.  Closing bug.