Bug 139948 – Fix build warning after r177700

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Hunseop Jeong]

../../Source/WebKit2/UIProcess/WebConnectionToWebProcess.cpp:53:21: warning: unused parameter ‘object’ [-Wunused-parameter]
 RefPtr<API::Object> WebConnectionToWebProcess::transformHandlesToObjects(API::Object* object)
                     ^
../../Source/WebKit2/UIProcess/WebConnectionToWebProcess.cpp:60:21: warning: unused parameter ‘object’ [-Wunused-parameter]
 RefPtr<API::Object> WebConnectionToWebProcess::transformObjectsToHandles(API::Object* object)

[Hunseop Jeong]

Created attachment 243751 [details]
Patch

[Hunseop Jeong]

Created attachment 243752 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 243752 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=243752&action=review

> Source/WebKit2/ChangeLog:3
> +        Unreviewed, fix build warning after r177700

Build warning should be reviewed. And also it would be good to get a review from WK2 owner.

> Source/WebKit2/UIProcess/WebConnectionToWebProcess.cpp:53
>  RefPtr<API::Object> WebConnectionToWebProcess::transformHandlesToObjects(API::Object* object)

In this case, I would recommend to remove object parameter here instead of UNUSED_PARAM().

> Source/WebKit2/UIProcess/WebConnectionToWebProcess.cpp:63
> +    UNUSED_PARAM(object);

ditto.

[Hunseop Jeong]

(In reply to comment #3)
> Comment on attachment 243752 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=243752&action=review
> 
> > Source/WebKit2/ChangeLog:3
> > +        Unreviewed, fix build warning after r177700
> 
> Build warning should be reviewed. And also it would be good to get a review
> from WK2 owner.
> 

Okay, I try to get a review from WK2 owner.

> > Source/WebKit2/UIProcess/WebConnectionToWebProcess.cpp:53
> >  RefPtr<API::Object> WebConnectionToWebProcess::transformHandlesToObjects(API::Object* object)
> 
> In this case, I would recommend to remove object parameter here instead of
> UNUSED_PARAM().
> 
> > Source/WebKit2/UIProcess/WebConnectionToWebProcess.cpp:63
> > +    UNUSED_PARAM(object);
> 
> ditto.

I removed the parameter instead of UNUSED_PARAM(). Thanks,

[Hunseop Jeong]

Created attachment 243753 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 243753 [details]
Patch

Clearing flags on attachment: 243753

Committed r177743: <http://trac.webkit.org/changeset/177743>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.