Bug 139941 – Engineering builds of MiniBrowser ignore deprecated declaration warnings

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

MiniBrowser builds with GCC_WARN_ABOUT_DEPRECATED_FUNCTIONS=NO even in the engineering configurations.

Created attachment 243738 [details]
Enable deprecation warnings

[Darin Adler]

Comment on attachment 243738 [details]
Enable deprecation warnings

View in context: https://bugs.webkit.org/attachment.cgi?id=243738&action=review

> Tools/MiniBrowser/mac/AppDelegate.m:167
> +#pragma clang diagnostic push
> +#pragma clang diagnostic ignored "-Wdeprecated-declarations"
>              if (result != NSOKButton)
>                  return;
> +#pragma clang diagnostic pop

I think we should be using NSFileHandlingPanelOKButton here instead of NSOKButton (not NSModalResponseOK), but I guess maybe that is not available in OS X 10.8 either.

> Tools/MiniBrowser/mac/AppDelegate.m:181
> +#pragma clang diagnostic push
> +#pragma clang diagnostic ignored "-Wdeprecated-declarations"
>          if (result != NSOKButton)
>              return;
> +#pragma clang diagnostic pop

Ditto.

(In reply to comment #2)
> Comment on attachment 243738 [details]
> Enable deprecation warnings
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=243738&action=review
> 
> > Tools/MiniBrowser/mac/AppDelegate.m:167
> > +#pragma clang diagnostic push
> > +#pragma clang diagnostic ignored "-Wdeprecated-declarations"
> >              if (result != NSOKButton)
> >                  return;
> > +#pragma clang diagnostic pop
> 
> I think we should be using NSFileHandlingPanelOKButton here instead of
> NSOKButton (not NSModalResponseOK), but I guess maybe that is not available
> in OS X 10.8 either.

Thanks for the suggestion! NSFileHandlingPanelOKButton is more appropriate and has been available since 10.10.

Fixed in <http://trac.webkit.org/r177731>.