Bug 139941 - Engineering builds of MiniBrowser ignore deprecated declaration warnings
Summary: Engineering builds of MiniBrowser ignore deprecated declaration warnings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: mitz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-24 21:48 PST by mitz
Modified: 2014-12-24 22:27 PST (History)
1 user (show)

See Also:


Attachments
Enable deprecation warnings (3.53 KB, patch)
2014-12-24 21:52 PST, mitz
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2014-12-24 21:48:17 PST
MiniBrowser builds with GCC_WARN_ABOUT_DEPRECATED_FUNCTIONS=NO even in the engineering configurations.
Comment 1 mitz 2014-12-24 21:52:02 PST
Created attachment 243738 [details]
Enable deprecation warnings
Comment 2 Darin Adler 2014-12-24 22:22:04 PST
Comment on attachment 243738 [details]
Enable deprecation warnings

View in context: https://bugs.webkit.org/attachment.cgi?id=243738&action=review

> Tools/MiniBrowser/mac/AppDelegate.m:167
> +#pragma clang diagnostic push
> +#pragma clang diagnostic ignored "-Wdeprecated-declarations"
>              if (result != NSOKButton)
>                  return;
> +#pragma clang diagnostic pop

I think we should be using NSFileHandlingPanelOKButton here instead of NSOKButton (not NSModalResponseOK), but I guess maybe that is not available in OS X 10.8 either.

> Tools/MiniBrowser/mac/AppDelegate.m:181
> +#pragma clang diagnostic push
> +#pragma clang diagnostic ignored "-Wdeprecated-declarations"
>          if (result != NSOKButton)
>              return;
> +#pragma clang diagnostic pop

Ditto.
Comment 3 mitz 2014-12-24 22:27:54 PST
(In reply to comment #2)
> Comment on attachment 243738 [details]
> Enable deprecation warnings
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=243738&action=review
> 
> > Tools/MiniBrowser/mac/AppDelegate.m:167
> > +#pragma clang diagnostic push
> > +#pragma clang diagnostic ignored "-Wdeprecated-declarations"
> >              if (result != NSOKButton)
> >                  return;
> > +#pragma clang diagnostic pop
> 
> I think we should be using NSFileHandlingPanelOKButton here instead of
> NSOKButton (not NSModalResponseOK), but I guess maybe that is not available
> in OS X 10.8 either.

Thanks for the suggestion! NSFileHandlingPanelOKButton is more appropriate and has been available since 10.10.

Fixed in <http://trac.webkit.org/r177731>.