Bug 139940 - [Cocoa] Some modern SPI changes have missing or incorrect availability annotations
Summary: [Cocoa] Some modern SPI changes have missing or incorrect availability annota...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: mitz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-24 21:26 PST by mitz
Modified: 2014-12-26 11:19 PST (History)
2 users (show)

See Also:

Attachments
Update availability annotations, add WK_DEPRECATED for the modern API (36.51 KB, patch)
2014-12-24 21:40 PST, mitz 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2014-12-24 21:26:03 PST 
Some recent changes to private headers in the modern API had missing or incorrect availability annotations.
Comment 1 mitz 2014-12-24 21:40:20 PST 
Created attachment 243736 [details]
Update availability annotations, add WK_DEPRECATED for the modern API
Comment 2 Darin Adler 2014-12-24 22:24:33 PST 
Comment on attachment 243736 [details]
Update availability annotations, add WK_DEPRECATED for the modern API

View in context: https://bugs.webkit.org/attachment.cgi?id=243736&action=review

> Source/WebKit2/ChangeLog:11
> +        to mean that the declaration is currently depracated. When API availability is enabled.

Typo: deprecated

Not sure I understand that last sentence fragment.
Comment 3 mitz 2014-12-24 22:30:12 PST 
(In reply to comment #2)
> Comment on attachment 243736 [details]
> Update availability annotations, add WK_DEPRECATED for the modern API
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=243736&action=review
> 
> > Source/WebKit2/ChangeLog:11
> > +        to mean that the declaration is currently depracated. When API availability is enabled.
> 
> Typo: deprecated
> 
> Not sure I understand that last sentence fragment.

I left that in by mistake!
Comment 4 mitz 2014-12-26 11:19:05 PST 
Fixed in <http://trac.webkit.org/r177747>.