Bug 139938 - Use std::unique_ptr<> in WebCore/dom, plugin, and graphics
Summary: Use std::unique_ptr<> in WebCore/dom, plugin, and graphics
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-24 17:56 PST by Gyuyoung Kim
Modified: 2014-12-25 20:07 PST (History)
7 users (show)

See Also:


Attachments
Patch (12.39 KB, patch)
2014-12-24 17:57 PST, Gyuyoung Kim
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews103 for mac-mountainlion (420.46 KB, application/zip)
2014-12-24 18:57 PST, Build Bot
no flags Details
Archive of layout-test-results from ews104 for mac-mountainlion-wk2 (434.08 KB, application/zip)
2014-12-24 18:59 PST, Build Bot
no flags Details
Patch for landing (11.12 KB, patch)
2014-12-25 09:12 PST, Gyuyoung Kim
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2014-12-24 17:56:16 PST
SSIA.
Comment 1 Gyuyoung Kim 2014-12-24 17:57:14 PST
Created attachment 243731 [details]
Patch
Comment 2 Build Bot 2014-12-24 18:57:53 PST
Comment on attachment 243731 [details]
Patch

Attachment 243731 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5121866435919872

Number of test failures exceeded the failure limit.
Comment 3 Build Bot 2014-12-24 18:57:56 PST
Created attachment 243732 [details]
Archive of layout-test-results from ews103 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 4 Build Bot 2014-12-24 18:59:41 PST
Comment on attachment 243731 [details]
Patch

Attachment 243731 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5746546880544768

Number of test failures exceeded the failure limit.
Comment 5 Build Bot 2014-12-24 18:59:44 PST
Created attachment 243733 [details]
Archive of layout-test-results from ews104 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 6 Myles C. Maxfield 2014-12-24 20:22:22 PST
Perhaps the crashes are caused by the bot not recompiling all the necessary files?

r=me assuming we get to the bottom of the crashes.
Comment 7 Darin Adler 2014-12-24 22:17:09 PST
Comment on attachment 243731 [details]
Patch

Change looks fine to me, but I am really worried about the test failures on the buildbots. Please find some way to check into that before landing.
Comment 8 Gyuyoung Kim 2014-12-25 09:12:21 PST
Created attachment 243743 [details]
Patch for landing
Comment 9 Gyuyoung Kim 2014-12-25 09:14:18 PST
(In reply to comment #7)
> Comment on attachment 243731 [details]
> Patch
> 
> Change looks fine to me, but I am really worried about the test failures on
> the buildbots. Please find some way to check into that before landing.

Test failures on ews seem to occur because #include <OwnPtr.h> were removed some files.
Comment 10 WebKit Commit Bot 2014-12-25 10:55:24 PST
Comment on attachment 243743 [details]
Patch for landing

Clearing flags on attachment: 243743

Committed r177737: <http://trac.webkit.org/changeset/177737>
Comment 11 WebKit Commit Bot 2014-12-25 10:55:29 PST
All reviewed patches have been landed.  Closing bug.
Comment 12 Myles C. Maxfield 2014-12-25 11:13:26 PST
(In reply to comment #9)
> (In reply to comment #7)
> > Comment on attachment 243731 [details]
> > Patch
> > 
> > Change looks fine to me, but I am really worried about the test failures on
> > the buildbots. Please find some way to check into that before landing.
> 
> Test failures on ews seem to occur because #include <OwnPtr.h> were removed
> some files.

And this didn't cause compile failures?
Comment 13 mitz 2014-12-25 14:43:38 PST
Did this change cause the errors seen here? <https://build.webkit.org/builders/Apple%20Win%20Debug%20%28Build%29/builds/84186>
Comment 14 Gyuyoung Kim 2014-12-25 17:43:25 PST
(In reply to comment #13)
> Did this change cause the errors seen here?
> <https://build.webkit.org/builders/Apple%20Win%20Debug%20%28Build%29/builds/
> 84186>


It seems to me that win debug build has been broken since r177729. I'm not fully sure if my commit caused the break.

https://build.webkit.org/builders/Apple%20Win%20Debug%20%28Build%29/builds/84177
Comment 15 Gyuyoung Kim 2014-12-25 17:44:41 PST
(In reply to comment #12)
> (In reply to comment #9)
> > (In reply to comment #7)
> > > Comment on attachment 243731 [details]
> > > Patch
> > > 
> > > Change looks fine to me, but I am really worried about the test failures on
> > > the buildbots. Please find some way to check into that before landing.
> > 
> > Test failures on ews seem to occur because #include <OwnPtr.h> were removed
> > some files.
> 
> And this didn't cause compile failures?

yes, it looks be weird. I will remove the OwnPtr.h soon. Let me check it again then.
Comment 16 mitz 2014-12-25 18:16:26 PST
(In reply to comment #14)
> (In reply to comment #13)
> > Did this change cause the errors seen here?
> > <https://build.webkit.org/builders/Apple%20Win%20Debug%20%28Build%29/builds/
> > 84186>
> 
> 
> It seems to me that win debug build has been broken since r177729. I'm not
> fully sure if my commit caused the break.
> 
> https://build.webkit.org/builders/Apple%20Win%20Debug%20%28Build%29/builds/
> 84177

The errors in build 84186 specifically appear to be related to this change.
Comment 17 Gyuyoung Kim 2014-12-25 18:19:58 PST
(In reply to comment #16)
> (In reply to comment #14)
> > (In reply to comment #13)
> > > Did this change cause the errors seen here?
> > > <https://build.webkit.org/builders/Apple%20Win%20Debug%20%28Build%29/builds/
> > > 84186>
> > 
> > 
> > It seems to me that win debug build has been broken since r177729. I'm not
> > fully sure if my commit caused the break.
> > 
> > https://build.webkit.org/builders/Apple%20Win%20Debug%20%28Build%29/builds/
> > 84177
> 
> The errors in build 84186 specifically appear to be related to this change.

Oh, I see. let me check it.
Comment 18 Gyuyoung Kim 2014-12-25 20:02:35 PST
(In reply to comment #17)
> (In reply to comment #16)
> > (In reply to comment #14)
> > > (In reply to comment #13)
> > > > Did this change cause the errors seen here?
> > > > <https://build.webkit.org/builders/Apple%20Win%20Debug%20%28Build%29/builds/
> > > > 84186>
> > > 
> > > 
> > > It seems to me that win debug build has been broken since r177729. I'm not
> > > fully sure if my commit caused the break.
> > > 
> > > https://build.webkit.org/builders/Apple%20Win%20Debug%20%28Build%29/builds/
> > > 84177
> > 
> > The errors in build 84186 specifically appear to be related to this change.
> 
> Oh, I see. let me check it.

I revert codes related to NoEventDispatchAssertion for win debug build, because it is hard to check this break on win bot for me now. Anyway it looks fine now. Let me check it in next time again.

https://build.webkit.org/builders/Apple%20Win%20Debug%20%28Build%29/builds/84188
Comment 19 mitz 2014-12-25 20:07:34 PST
(In reply to comment #18)

> I revert codes related to NoEventDispatchAssertion for win debug build,
> because it is hard to check this break on win bot for me now. Anyway it
> looks fine now. Let me check it in next time again.
> 
> https://build.webkit.org/builders/Apple%20Win%20Debug%20%28Build%29/builds/
> 84188

Thank you for fixing the build!