Bug 139916 – Simplify building with ASan

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Alexey Proskuryakov]

Make the following work:

set-webkit-configuration --[no]-asan

Building will just work after this, provided that the installed toolchain supports ASan.

make ASAN=(YES|NO)

This will be equivalent to running set-webkit-configuration, and then make.

Running the binaries in all normal ways will work too, with some caveats (notably, no symbolication, and somewhat broken run-webkit-tests integration).

[Alexey Proskuryakov]

Created attachment 243695 [details]
proposed patch

[Mark Rowe (bdash)]

Comment on attachment 243695 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=243695&action=review

> Makefile.shared:60
> +ifneq (,$(ASAN))
> +	$(SCRIPTS_PATH)/set-webkit-configuration $(ASAN_OPTION)
> +endif

This may run set-webkit-configuration when ASAN_OPTIONS hasn't been set, such as if ASAN=foo is passed. Should we guard this on whether ASAN_OPTION is set instead?

> Tools/Scripts/webkitdirs.pm:366
> +    if (open ASAN, "$baseProductDir/ASan") {
> +        $asanConfigurationValue = <ASAN>;
> +        close ASAN;
> +    }
> +    if ($asanConfigurationValue) {
> +        chomp $asanConfigurationValue;
> +        $asanIsEnabled = 1 if $asanConfigurationValue eq "YES";
> +    }

Is there a reason to use two if blocks here? Isn't it safe to assume $asanConfigurationValue is defined if we were able to open the file?

> Tools/asan/asan.xcconfig:12
> +ASAN_OTHER_LDFLAGS = -fsanitize=address
> +
> +GCC_ENABLE_OBJC_GC = NO

Semicolons at end of line.

[Alexey Proskuryakov]

> Should we guard this on whether ASAN_OPTION is set instead?

Yes, this makes the behavior consistent with "make debug ASAN=foo".

> Is there a reason to use two if blocks here? Isn't it safe to assume $asanConfigurationValue is defined if we were able to open the file?

Probably not, was just following what we do for configuration. I'll merge these.

[Alexey Proskuryakov]

Committed <http://trac.webkit.org/r177703>.