Bug 139909 – Rename WebContext to WebProcessPool

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Sam Weinig]

Rename WebContext to WebProcessPool

[Sam Weinig]

Created attachment 243684 [details]
Patch

[WebKit Commit Bot]

Attachment 243684 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/APIProcessPoolConfiguration.h:26:  #ifndef header guard has wrong style, please use: APIProcessPoolConfiguration_h  [build/header_guard] [5]
ERROR: Source/WebKit2/UIProcess/WebProcessPool.h:279:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/WebProcessPool.cpp:199:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebKit2/UIProcess/WebProcessPool.cpp:343:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/WebKit2/UIProcess/WebProcessPool.cpp:885:  One line control clauses should not use braces.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/WebProcessPool.cpp:1330:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/WebProcessPool.cpp:1358:  One line control clauses should not use braces.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/WebProcessPoolCocoa.mm:33:  "WKBrowsingContextControllerInternal.h" already included at Source/WebKit2/UIProcess/Cocoa/WebProcessPoolCocoa.mm:32  [build/include] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/WebProcessPoolCocoa.mm:219:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/WebProcessPoolCocoa.mm:219:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/WebProcessPoolCocoa.mm:524:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/WebProcessPoolCocoa.mm:528:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/WebProcessPoolCocoa.mm:533:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/WebProcessPoolCocoa.mm:539:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/WebProcessPoolCocoa.mm:544:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/ChangeLog:13:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Total errors found: 16 in 103 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Chris Dumez]

May have broken iOS build:
Source/WebKit2/UIProcess/ios/WKContentView.h:64:58: error: expected a type
- (instancetype)initWithFrame:(CGRect)frame processPool:(WebProcessPool&)processPool configuration:(WebKit::WebPageConfiguration)webPageConfiguration webView:(WKWebView *)webView;

[Chris Dumez]

(In reply to comment #3)
> May have broken iOS build:
> Source/WebKit2/UIProcess/ios/WKContentView.h:64:58: error: expected a type
> - (instancetype)initWithFrame:(CGRect)frame
> processPool:(WebProcessPool&)processPool
> configuration:(WebKit::WebPageConfiguration)webPageConfiguration
> webView:(WKWebView *)webView;

Build fix landed in <http://trac.webkit.org/changeset/177707>.

[Chris Dumez]

BTW, this bug is still open but it looks like it already landed in http://trac.webkit.org/changeset/177692 ?

[Chris Dumez]

There are actually more build failures on iOS :(

Source/WebKit2/UIProcess/API/Cocoa/WKProcessGroup.mm:238:90: error: use of undeclared identifier '_context'
        _geolocationProvider = adoptNS([[WKGeolocationProviderIOS alloc] initWithContext:_context.get()]);

Source/WebKit2/UIProcess/API/ios/WKViewIOS.mm:228:80: error: initialization of incomplete type 'WebKit::WebProcessPool'
    _contentView = adoptNS([[WKContentView alloc] initWithFrame:bounds context:*toImpl(contextRef) configuration:WTF::move(webPageConfiguration) webView:nil]);

For the second one, adding the right include is not sufficient as it will complain about missing copy constructor:
Source/WebKit2/UIProcess/API/ios/WKViewIOS.mm:229:80: error: call to implicitly-deleted copy constructor of 'WebKit::WebProcessPool'
    _contentView = adoptNS([[WKContentView alloc] initWithFrame:bounds context:*toImpl(contextRef) configuration:WTF::move(webPageConfiguration) webView:nil]);
                                                                               ^~~~~~~~~~~~~~~~~~~
In file included from Source/WebKit2/UIProcess/API/ios/WKViewIOS.mm:34:
Source/WebKit2/UIProcess/WebProcessPool.h:473:23: note: copy constructor of 'WebProcessPool' is implicitly deleted because field 'm_defaultPageGroup' has a deleted copy constructor
    Ref<WebPageGroup> m_defaultPageGroup;

[Sam Weinig]

(In reply to comment #6)
> There are actually more build failures on iOS :(
> 
> Source/WebKit2/UIProcess/API/Cocoa/WKProcessGroup.mm:238:90: error: use of
> undeclared identifier '_context'
>         _geolocationProvider = adoptNS([[WKGeolocationProviderIOS alloc]
> initWithContext:_context.get()]);
> 
> Source/WebKit2/UIProcess/API/ios/WKViewIOS.mm:228:80: error: initialization
> of incomplete type 'WebKit::WebProcessPool'
>     _contentView = adoptNS([[WKContentView alloc] initWithFrame:bounds
> context:*toImpl(contextRef) configuration:WTF::move(webPageConfiguration)
> webView:nil]);
> 
> For the second one, adding the right include is not sufficient as it will
> complain about missing copy constructor:
> Source/WebKit2/UIProcess/API/ios/WKViewIOS.mm:229:80: error: call to
> implicitly-deleted copy constructor of 'WebKit::WebProcessPool'
>     _contentView = adoptNS([[WKContentView alloc] initWithFrame:bounds
> context:*toImpl(contextRef) configuration:WTF::move(webPageConfiguration)
> webView:nil]);
>                                                                             
> ^~~~~~~~~~~~~~~~~~~
> In file included from Source/WebKit2/UIProcess/API/ios/WKViewIOS.mm:34:
> Source/WebKit2/UIProcess/WebProcessPool.h:473:23: note: copy constructor of
> 'WebProcessPool' is implicitly deleted because field 'm_defaultPageGroup'
> has a deleted copy constructor
>     Ref<WebPageGroup> m_defaultPageGroup;

Attempted fix landed in r177710.

[Gyuyoung Kim]

EFL and GTK ports have been broken since this patch. I upload a patch for EFL port for now.

https://bugs.webkit.org/show_bug.cgi?id=139932

[Csaba Osztrogonác]

Let's close it, the original patch and all buildfixes already landed.

[Csaba Osztrogonác]

GTK fix landed in http://trac.webkit.org/changeset/177721