Bug 139892 - Use ctiPatchCallByReturnAddress() in JITOperations.cpp
Summary: Use ctiPatchCallByReturnAddress() in JITOperations.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-22 18:05 PST by Mark Lam
Modified: 2014-12-22 18:48 PST (History)
1 user (show)

See Also:


Attachments
the patch. (3.57 KB, patch)
2014-12-22 18:10 PST, Mark Lam
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2014-12-22 18:05:58 PST
The code in JITOperations.cpp is sometimes calling RepatchBuffer::relinkCallerToFunction() directly, and sometimes using a helper function, ctiPatchCallByReturnAddress().  This patch changes it to use the helper function consistently.
Comment 1 Mark Lam 2014-12-22 18:10:42 PST
Created attachment 243656 [details]
the patch.

The perf numbers shows that perf is a neutral with this patch.
Comment 2 Michael Saboff 2014-12-22 18:13:28 PST
Comment on attachment 243656 [details]
the patch.

r=me
Comment 3 WebKit Commit Bot 2014-12-22 18:48:10 PST
Comment on attachment 243656 [details]
the patch.

Clearing flags on attachment: 243656

Committed r177675: <http://trac.webkit.org/changeset/177675>
Comment 4 WebKit Commit Bot 2014-12-22 18:48:12 PST
All reviewed patches have been landed.  Closing bug.