Bug 139889 – Some compositing reflections tests are broken

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Simon Fraser (smfr)]

Running pixel tests shows some compositing tests which fail now:

compositing/reflections/animation-inside-reflection.html
compositing/reflections/compositing-change-inside-reflection.html
compositing/reflections/masked-reflection-on-composited.html
compositing/reflections/nested-reflection-on-overflow.html
compositing/reflections/reflection-opacity.html
compositing/reflections/remove-add-reflection.html
compositing/reflections/transform-inside-reflection.html

Regression range:
http://trac.webkit.org/log/trunk/?rev=160672&stop_rev=160666
so probably http://trac.webkit.org/changeset/160672

[Simon Fraser (smfr)]

PlatformCALayerMac::updateCustomAppearance() nukes the background color under ScrollbarThemeMac::removeOverhangAreaBackground().

[Simon Fraser (smfr)]

Created attachment 244104 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 244104 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=244104&action=review

> Source/WebCore/rendering/RenderGeometryMap.cpp:143
> +//    ASSERT(enclosingIntRect(rendererMappedResult) == enclosingIntRect(FloatQuad(result).boundingBox()));
> +    if (enclosingIntRect(rendererMappedResult) != enclosingIntRect(FloatQuad(result).boundingBox()))
> +        WTFLogAlways("Wah\n");

Ignore this bit.

[Tim Horton]

Comment on attachment 244104 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=244104&action=review

> Source/WebCore/ChangeLog:9
> +        color via resetting the custom appearance on the clone. Fix by having

And it's OK to do this because we won't have reflections on custom appearance'd things? Can we add an assertion to that effect?

> Source/WebCore/rendering/RenderGeometryMap.cpp:141
> +//    ASSERT(enclosingIntRect(rendererMappedResult) == enclosingIntRect(FloatQuad(result).boundingBox()));

no.

> Source/WebCore/rendering/RenderGeometryMap.cpp:143
> +        WTFLogAlways("Wah\n");

no.

[Simon Fraser (smfr)]

(In reply to comment #4)
> Comment on attachment 244104 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=244104&action=review
> 
> > Source/WebCore/ChangeLog:9
> > +        color via resetting the custom appearance on the clone. Fix by having
> 
> And it's OK to do this because we won't have reflections on custom
> appearance'd things? Can we add an assertion to that effect?

We are actually just copying over the custom appearance from the original.

[Simon Fraser (smfr)]

https://trac.webkit.org/r178002