Bug 139861 - [MSE] Implement Append Window support.
Summary: [MSE] Implement Append Window support.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-22 06:26 PST by Bartlomiej Gajda
Modified: 2015-01-09 09:16 PST (History)
2 users (show)

See Also:

Attachments
implement appendwindow v1 (8.59 KB, patch)
2014-12-22 06:30 PST, Bartlomiej Gajda 		no flags Details | Formatted Diff | Diff
implement appendwindow v1+layouttest (14.60 KB, patch)
2015-01-09 06:29 PST, Bartlomiej Gajda 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bartlomiej Gajda 2014-12-22 06:26:29 PST 
There is no support for SourceBuffer.appendWindowStart and SourceBuffer.appendWindowEnd yet.
Comment 1 Bartlomiej Gajda 2014-12-22 06:30:11 PST 
Created attachment 243622 [details]
implement appendwindow v1

Added appendWindowStart, appendWindowEnd and missing logic; also reordered idl to match order from spec.
Comment 2 Jer Noble 2015-01-05 10:19:27 PST 
Comment on attachment 243622 [details]
implement appendwindow v1

The patch looks good, but it needs a layout test.
Comment 3 Bartlomiej Gajda 2015-01-09 06:29:15 PST 
Created attachment 244339 [details]
implement appendwindow v1+layouttest

added LayoutTest which adds same range 3 times with different appendWindows and checks for buffered.
Comment 4 Jer Noble 2015-01-09 08:36:13 PST 
Comment on attachment 244339 [details]
implement appendwindow v1+layouttest

Nice!
Comment 5 WebKit Commit Bot 2015-01-09 09:16:16 PST 
Comment on attachment 244339 [details]
implement appendwindow v1+layouttest

Clearing flags on attachment: 244339

Committed r178172: <http://trac.webkit.org/changeset/178172>
Comment 6 WebKit Commit Bot 2015-01-09 09:16:19 PST 
All reviewed patches have been landed.  Closing bug.