Bug 139857 - Allow the WebContext's history client to coexist with WKWebView's history delegate
Summary: Allow the WebContext's history client to coexist with WKWebView's history del...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-21 13:41 PST by Sam Weinig
Modified: 2014-12-22 11:04 PST (History)
0 users

See Also:

Attachments
Patch (61.37 KB, patch)
2014-12-21 13:46 PST, Sam Weinig 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2014-12-21 13:41:25 PST 
Allow the WebContext's history client to coexist with WKWebView's history delegate
Comment 1 Sam Weinig 2014-12-21 13:46:39 PST 
Created attachment 243615 [details]
Patch
Comment 2 Anders Carlsson 2014-12-22 09:02:09 PST 
Comment on attachment 243615 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=243615&action=review

> Source/WebKit2/UIProcess/WebPageProxy.cpp:3081
> +    // Notify the loader client.

I don't think this comment is useful.

> Source/WebKit2/UIProcess/WebPageProxy.cpp:3084
> +    // Also, notify the legacy history client on the WebContext.

Same here (and all the other comments that say the same thing!)
Comment 3 Sam Weinig 2014-12-22 11:04:47 PST 
Committed r177636: <http://trac.webkit.org/changeset/177636>