WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
139857
Allow the WebContext's history client to coexist with WKWebView's history delegate
https://bugs.webkit.org/show_bug.cgi?id=139857
Summary
Allow the WebContext's history client to coexist with WKWebView's history del...
Sam Weinig
Reported
2014-12-21 13:41:25 PST
Allow the WebContext's history client to coexist with WKWebView's history delegate
Attachments
Patch
(61.37 KB, patch)
2014-12-21 13:46 PST
,
Sam Weinig
andersca
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Sam Weinig
Comment 1
2014-12-21 13:46:39 PST
Created
attachment 243615
[details]
Patch
Anders Carlsson
Comment 2
2014-12-22 09:02:09 PST
Comment on
attachment 243615
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=243615&action=review
> Source/WebKit2/UIProcess/WebPageProxy.cpp:3081 > + // Notify the loader client.
I don't think this comment is useful.
> Source/WebKit2/UIProcess/WebPageProxy.cpp:3084 > + // Also, notify the legacy history client on the WebContext.
Same here (and all the other comments that say the same thing!)
Sam Weinig
Comment 3
2014-12-22 11:04:47 PST
Committed
r177636
: <
http://trac.webkit.org/changeset/177636
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug