RESOLVED FIXED 139836
[SVG -> OTF Converter] Make placeholders more robust 
https://bugs.webkit.org/show_bug.cgi?id=139836
Summary [SVG -> OTF Converter] Make placeholders more robust
Myles C. Maxfield
Reported 2014-12-19 15:06:03 PST
[SVG -> OTF Converter] Make placeholders more robust
Attachments
Patch (4.67 KB, patch)
2014-12-19 15:07 PST, Myles C. Maxfield 		mitz: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2014-12-19 15:07:13 PST
Created attachment 243580 [details] Patch
mitz
Comment 2 2014-12-19 15:35:13 PST
Comment on attachment 243580 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=243580&action=review > Source/WebCore/svg/SVGToOTFFontConversion.cpp:93 > + { Perhaps ASSERT(!m_written) here? > Source/WebCore/svg/SVGToOTFFontConversion.cpp:614 > + Placeholder toCoverageTable(*this, subtableLocation); I think it would have been a little nicer if SVGToOTFFontConverter had a member function that returned a placeholder (and then the Placeholder constructor could be private and friend with that member function), so here you’d just say auto toCoverageTable = appendPlaceholder(subtableLocation);
Myles C. Maxfield
Comment 3 2014-12-19 20:28:40 PST
Comment on attachment 243580 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=243580&action=review >> Source/WebCore/svg/SVGToOTFFontConversion.cpp:93 >> + { > > Perhaps ASSERT(!m_written) here? Done. >> Source/WebCore/svg/SVGToOTFFontConversion.cpp:614 >> + Placeholder toCoverageTable(*this, subtableLocation); > > I think it would have been a little nicer if SVGToOTFFontConverter had a member function that returned a placeholder (and then the Placeholder constructor could be private and friend with that member function), so here you’d just say > auto toCoverageTable = appendPlaceholder(subtableLocation); Done.
Myles C. Maxfield
Comment 4 2014-12-19 20:42:11 PST
Committed r177620: <http://trac.webkit.org/changeset/177620>
Note You need to log in before you can comment on or make changes to this bug.