Bug 139836 - [SVG -> OTF Converter] Make placeholders more robust
Summary: [SVG -> OTF Converter] Make placeholders more robust
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-19 15:06 PST by Myles C. Maxfield
Modified: 2014-12-19 20:42 PST (History)
12 users (show)

See Also:

Attachments
Patch (4.67 KB, patch)
2014-12-19 15:07 PST, Myles C. Maxfield 		mitz: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2014-12-19 15:06:03 PST 
[SVG -> OTF Converter] Make placeholders more robust
Comment 1 Myles C. Maxfield 2014-12-19 15:07:13 PST 
Created attachment 243580 [details]
Patch
Comment 2 mitz 2014-12-19 15:35:13 PST 
Comment on attachment 243580 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=243580&action=review

> Source/WebCore/svg/SVGToOTFFontConversion.cpp:93
> +        {

Perhaps ASSERT(!m_written) here?

> Source/WebCore/svg/SVGToOTFFontConversion.cpp:614
> +    Placeholder toCoverageTable(*this, subtableLocation);

I think it would have been a little nicer if SVGToOTFFontConverter had a member function that returned a placeholder (and then the Placeholder constructor could be private and friend with that member function), so here you’d just say
auto toCoverageTable = appendPlaceholder(subtableLocation);
Comment 3 Myles C. Maxfield 2014-12-19 20:28:40 PST 
Comment on attachment 243580 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=243580&action=review

>> Source/WebCore/svg/SVGToOTFFontConversion.cpp:93
>> +        {
> 
> Perhaps ASSERT(!m_written) here?

Done.

>> Source/WebCore/svg/SVGToOTFFontConversion.cpp:614
>> +    Placeholder toCoverageTable(*this, subtableLocation);
> 
> I think it would have been a little nicer if SVGToOTFFontConverter had a member function that returned a placeholder (and then the Placeholder constructor could be private and friend with that member function), so here you’d just say
> auto toCoverageTable = appendPlaceholder(subtableLocation);

Done.
Comment 4 Myles C. Maxfield 2014-12-19 20:42:11 PST 
Committed r177620: <http://trac.webkit.org/changeset/177620>