Add prefixed API for optimized fullscreen.
Created attachment 243578 [details] Proposed patch.
Attachment 243578 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] ERROR: Source/WebCore/dom/EventNames.h:298: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/dom/EventNames.h:300: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 3 in 19 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 243578 [details] Proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=243578&action=review > Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig:229 > +ENABLE_VIDEO_PRESENTATION_MODE[sdk=iphone*] = ENABLE_VIDEO_PRESENTATION_MODE; Please sort this alphabetically with the other ENABLE_ (here and other FeatureDefines.xcconfig files) > Source/WTF/wtf/Platform.h:1103 > +#if PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 90000 > +#define ENABLE_VIDEO_PRESENTATION_MODE 1 > +#endif I don't think you need this at all, since the xcconfig files define this. Or is it needed for the IDL? > Source/WebCore/ChangeLog:8 > + No new tests (OOPS!). OOPS Can you add some iOS tests? > Source/WebCore/html/HTMLVideoElement.cpp:408 > + if (mode == VideoFullscreenModeStandard) > + return presentationModeFullscreen(); > + if (mode & VideoFullscreenModeOptimized) > + return presentationModeOptimized(); > + if (mode == VideoFullscreenModeNone) > + return presentationModeInline(); I would prefer a blank line after each return.
Submitted r177622: https://trac.webkit.org/r177622