Bug 139832 – Plug leak below LLVMCopyStringRepOfTargetData().

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Andreas Kling]

Plug leak below LLVMCopyStringRepOfTargetData().

[Andreas Kling]

Created attachment 243571 [details]
Patch

[Michael Saboff]

Comment on attachment 243571 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=243571&action=review

r=me

> Source/JavaScriptCore/ftl/FTLCompile.cpp:648
> +        llvm->SetDataLayout(state.module, stringRepOfTargetData);

Does SetDataLayout need the string after it returns or does it copy out its contents?

[Andreas Kling]

(In reply to comment #2)
> Comment on attachment 243571 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=243571&action=review
> 
> r=me

You forgot to tick r+ :-)

> > Source/JavaScriptCore/ftl/FTLCompile.cpp:648
> > +        llvm->SetDataLayout(state.module, stringRepOfTargetData);
> 
> Does SetDataLayout need the string after it returns or does it copy out its
> contents?

It assigns it to an std::string internally, making a copy.

[WebKit Commit Bot]

Comment on attachment 243571 [details]
Patch

Clearing flags on attachment: 243571

Committed r177597: <http://trac.webkit.org/changeset/177597>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.