RESOLVED FIXED Bug 139826
REGRESSION (177368): Some tests started to immediately time out 
https://bugs.webkit.org/show_bug.cgi?id=139826
Summary REGRESSION (177368): Some tests started to immediately time out
Alexey Proskuryakov
Reported 2014-12-19 12:03:03 PST
fast/repaint/no-animation-outside-viewport-subframe.html has started to frequently fail on December 16. It's not a true failure, but a problem anyway. For some reason, waitUntilDone watchdog timer fires almost immediately - logs say that the test timed out, but also that it only took 0.1 second! https://build.webkit.org/builders/Apple%20Mavericks%20Release%20WK2%20(Tests)/builds/10221/steps/layout-test/logs/stdio 11:28:23.653 74860 Tests that timed out or crashed: ... 11:28:23.654 74860 fast/repaint/no-animation-outside-viewport-subframe.html took 0.1 seconds
Attachments
proposed fix (4.54 KB, patch)
2014-12-19 14:50 PST, Alexey Proskuryakov 		dbates: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2014-12-19 12:13:11 PST
Antti wrote this test, maybe he has an idea.
Alexey Proskuryakov
Comment 2 2014-12-19 12:14:52 PST
This looks like a problem with deeper WebCore or DumpRenderTree machinery, like DOM timers being broken.
Alexey Proskuryakov
Comment 3 2014-12-19 12:46:23 PST
This happens on other tests too, just happened for the first time on fast/text/international/lang-sensitive-fonts-xml.xhtml. So far, looks like WebKit2 only.
Alexey Proskuryakov
Comment 4 2014-12-19 13:45:59 PST
My theory is that this is some deficiency in WebKitTestRunner watchdog timer behavior, we might leak it across tests. Looking into this.
Alexey Proskuryakov
Comment 5 2014-12-19 14:40:54 PST
The reason why this regressed is that I unskipped a test that breaks a consequent test 30 seconds later!
Alexey Proskuryakov
Comment 6 2014-12-19 14:50:37 PST
Created attachment 243579 [details] proposed fix
Daniel Bates
Comment 7 2014-12-19 14:54:07 PST
Comment on attachment 243579 [details] proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=243579&action=review > Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp:165 > + // than to let webkitpy do that, becasue WebKitTestRunner will dump partial results. Nit: ", because" => because
Daniel Bates
Comment 8 2014-12-19 14:57:13 PST
Do we need something similar for DumpRenderTree?
Alexey Proskuryakov
Comment 9 2014-12-19 15:25:06 PST
> Do we need something similar for DumpRenderTree? I'm checking that. It looks like the bug exists there too, but it's much less of a problem due to the timer being a global.
Alexey Proskuryakov
Comment 10 2014-12-19 15:26:06 PST
Committed <http://trac.webkit.org/r177598>.
Alexey Proskuryakov
Comment 11 2014-12-19 15:28:15 PST
Actually, DumpRenderTree seems fine, we always go through dumpTestResults() there.
Note You need to log in before you can comment on or make changes to this bug.