Bug 139821 – REGRESSION(r177574): "Broke Production builds by installing libWebCoreTestSupport.dylib in the wrong directory" (Requested by ddkilzer on #webkit).

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[WebKit Commit Bot]

http://trac.webkit.org/changeset/177574 broke the build:
"Broke Production builds by installing libWebCoreTestSupport.dylib in the wrong directory" (Requested by ddkilzer on #webkit).

This is an automatic bug report generated by webkitbot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests fail.

[WebKit Commit Bot]

Created attachment 243557 [details]
ROLLOUT of r177574

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.

[WebKit Commit Bot]

Comment on attachment 243557 [details]
ROLLOUT of r177574

Clearing flags on attachment: 243557

Committed r177580: <http://trac.webkit.org/changeset/177580>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[David Kilzer (:ddkilzer)]

The DumpRenderTree-can't-link-to-libWebCoreTestSupport.dylib issue is due to the wrong directory being used:

-SymLink /Volumes/Data/slave/yosemite-production-archive/build/build-Production/WebCore.roots/BuildRecords/WebCore_install/Symbols/BuiltProducts/libWebCoreTestSupport.dylib /Volumes/Data/slave/yosemite-production-archive/build/build-Production/WebCore.roots/BuildRecords/WebCore_install/Root/usr/local/lib/libWebCoreTestSupport.dylib
+SymLink /Volumes/Data/slave/yosemite-production-archive/build/build-Production/WebCore.roots/BuildRecords/WebCore_install/Symbols/BuiltProducts/libWebCoreTestSupport.dylib /Volumes/Data/slave/yosemite-production-archive/build/build-Production/WebCore.roots/BuildRecords/WebCore_install/Root/System/Library/Frameworks/WebKit.framework/Versions/A/Frameworks/libWebCoreTestSupport.dylib

So it looks like some value in WebCoreTestSupport.xcconfig wasn't being overridden properly, probably INSTALL_PATH.

[David Kilzer (:ddkilzer)]

I also noticed that the order file wasn't being set for JavaScriptCore and WebCore builds.

This leads me to believe that doing things like this just lead to unexpected behavior and sadness (namely the variables are never set when building with xcodebuild, but look fine with using the Xcode UI):

+SECTORDER_FLAGS[sdk=iphoneos*][config=Production] = -Wl,-order_file,$(SDKROOT)/AppleInternal/OrderFiles/JavaScriptCore.order;
+SECTORDER_FLAGS[sdk=macosx*][config=Production] = -Wl,-order_file,JavaScriptCore.order;

[David Kilzer (:ddkilzer)]

Re-landed with [config=] selectors removed:

Committed r177621: <http://trac.webkit.org/changeset/177621>

See Bug 139463.