WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
139817
[Win] Add accessor for serializing HTTP loads
https://bugs.webkit.org/show_bug.cgi?id=139817
Summary
[Win] Add accessor for serializing HTTP loads
Brent Fulgham
Reported
2014-12-19 09:34:40 PST
Add a test helper method so that we can tell WebKit to serialize HTTP loads. This is used for Mac (and other) platform testing, but is missing on Windows.
Attachments
Patch
(5.15 KB, patch)
2014-12-19 09:42 PST
,
Brent Fulgham
mark.lam
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Brent Fulgham
Comment 1
2014-12-19 09:42:57 PST
Created
attachment 243553
[details]
Patch
Brent Fulgham
Comment 2
2014-12-19 09:43:40 PST
Comment on
attachment 243553
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=243553&action=review
> Tools/DumpRenderTree/win/TestRunnerWin.cpp:-70 > -
This is being done in our reset method. No need to call in destructor.
Mark Lam
Comment 3
2014-12-19 10:47:16 PST
Comment on
attachment 243553
[details]
Patch rs=me
Brent Fulgham
Comment 4
2014-12-19 10:48:06 PST
(In reply to
comment #2
)
> Comment on
attachment 243553
[details]
> Patch > > View in context: >
https://bugs.webkit.org/attachment.cgi?id=243553&action=review
> > > Tools/DumpRenderTree/win/TestRunnerWin.cpp:-70 > > - > > This is being done in our reset method. No need to call in destructor.
Note: This is being done in DumpRenderTree.cpp::resetWebViewToConsistentStateBeforeTesting. There is no need to also call it in the destructor. I'm removing code in the destructor to make the Windows runs behave more consistently like the Mac versions.
Brent Fulgham
Comment 5
2014-12-19 10:58:57 PST
Committed
r177579
: <
http://trac.webkit.org/changeset/177579
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug