Bug 139817 - [Win] Add accessor for serializing HTTP loads
Summary: [Win] Add accessor for serializing HTTP loads
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-19 09:34 PST by Brent Fulgham
Modified: 2014-12-19 10:58 PST (History)
1 user (show)

See Also:

Attachments
Patch (5.15 KB, patch)
2014-12-19 09:42 PST, Brent Fulgham 		mark.lam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2014-12-19 09:34:40 PST 
Add a test helper method so that we can tell WebKit to serialize HTTP loads. This is used for Mac (and other) platform testing, but is missing on Windows.
Comment 1 Brent Fulgham 2014-12-19 09:42:57 PST 
Created attachment 243553 [details]
Patch
Comment 2 Brent Fulgham 2014-12-19 09:43:40 PST 
Comment on attachment 243553 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=243553&action=review

> Tools/DumpRenderTree/win/TestRunnerWin.cpp:-70
> -

This is being done in our reset method. No need to call in destructor.
Comment 3 Mark Lam 2014-12-19 10:47:16 PST 
Comment on attachment 243553 [details]
Patch

rs=me
Comment 4 Brent Fulgham 2014-12-19 10:48:06 PST 
(In reply to comment #2)
> Comment on attachment 243553 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=243553&action=review
> 
> > Tools/DumpRenderTree/win/TestRunnerWin.cpp:-70
> > -
> 
> This is being done in our reset method. No need to call in destructor.

Note: This is being done in DumpRenderTree.cpp::resetWebViewToConsistentStateBeforeTesting. There is no need to also call it in the destructor. I'm removing code in the destructor to make the Windows runs behave more consistently like the Mac versions.
Comment 5 Brent Fulgham 2014-12-19 10:58:57 PST 
Committed r177579: <http://trac.webkit.org/changeset/177579>