Bug 139799 - [Win] Update DumpRenderTree to more closely match Mac version
Summary: [Win] Update DumpRenderTree to more closely match Mac version
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords:
Depends on: 139972
Blocks:
  Show dependency tree / graph
 
Reported: 2014-12-18 16:34 PST by Brent Fulgham
Modified: 2014-12-28 02:35 PST (History)
2 users (show)

See Also:

Attachments
Patch (49.75 KB, patch)
2014-12-18 16:44 PST, Brent Fulgham 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2014-12-18 16:34:30 PST 
Reorder the contents of the Windows implementation of DumpRenderTree so that it is easier to compare the steps taken when starting and ending our layout tests.

Also implement a handful of functions so that Windows does a better job of handling its caches and other local storage.
Comment 1 Brent Fulgham 2014-12-18 16:44:28 PST 
Created attachment 243533 [details]
Patch
Comment 2 WebKit Commit Bot 2014-12-18 16:46:27 PST 
Attachment 243533 [details] did not pass style-queue:


ERROR: Tools/DumpRenderTree/win/DumpRenderTree.cpp:56:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebKit/win/WebSecurityOrigin.cpp:32:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 2 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Tim Horton 2014-12-18 16:46:34 PST 
Comment on attachment 243533 [details]
Patch

rs=me
Comment 4 Brent Fulgham 2014-12-18 17:00:26 PST 
Committed r177542: <http://trac.webkit.org/changeset/177542>