Bug 139793 - Change page preview loading order, and add a TextIndicator
Summary: Change page preview loading order, and add a TextIndicator
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-18 14:01 PST by Tim Horton
Modified: 2014-12-18 16:12 PST (History)
10 users (show)

See Also:

Attachments
Patch (55.91 KB, patch)
2014-12-18 14:02 PST, Tim Horton 		bdakin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2014-12-18 14:01:43 PST 
Change page preview loading order, and add a TextIndicator
Comment 1 Tim Horton 2014-12-18 14:02:26 PST 
Created attachment 243518 [details]
Patch
Comment 2 WebKit Commit Bot 2014-12-18 14:03:45 PST 
Attachment 243518 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/spi/mac/NSPopoverSPI.h:41:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/mac/WKPreviewPopoverAnimationController.mm:325:  The parameter name "url" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Beth Dakin 2014-12-18 14:11:45 PST 
Comment on attachment 243518 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=243518&action=review

> Source/WebKit2/UIProcess/mac/WKImmediateActionController.mm:244
> +

Unnecessary whitespace?
Comment 4 Tim Horton 2014-12-18 14:15:03 PST 
http://trac.webkit.org/changeset/177522
Comment 5 Tim Horton 2014-12-18 14:30:12 PST 
http://trac.webkit.org/changeset/177525
Comment 6 Tim Horton 2014-12-18 16:12:53 PST 
http://trac.webkit.org/changeset/177539