RESOLVED FIXED 139793
Change page preview loading order, and add a TextIndicator 
https://bugs.webkit.org/show_bug.cgi?id=139793
Summary Change page preview loading order, and add a TextIndicator
Tim Horton
Reported 2014-12-18 14:01:43 PST
Change page preview loading order, and add a TextIndicator
Attachments
Patch (55.91 KB, patch)
2014-12-18 14:02 PST, Tim Horton 		bdakin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2014-12-18 14:02:26 PST
Created attachment 243518 [details] Patch
WebKit Commit Bot
Comment 2 2014-12-18 14:03:45 PST
Attachment 243518 [details] did not pass style-queue: ERROR: Source/WebCore/platform/spi/mac/NSPopoverSPI.h:41: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKit2/UIProcess/mac/WKPreviewPopoverAnimationController.mm:325: The parameter name "url" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 16 files If any of these errors are false positives, please file a bug against check-webkit-style.
Beth Dakin
Comment 3 2014-12-18 14:11:45 PST
Comment on attachment 243518 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=243518&action=review > Source/WebKit2/UIProcess/mac/WKImmediateActionController.mm:244 > + Unnecessary whitespace?
Tim Horton
Comment 4 2014-12-18 14:15:03 PST
http://trac.webkit.org/changeset/177522
Tim Horton
Comment 5 2014-12-18 14:30:12 PST
http://trac.webkit.org/changeset/177525
Tim Horton
Comment 6 2014-12-18 16:12:53 PST
http://trac.webkit.org/changeset/177539
Note You need to log in before you can comment on or make changes to this bug.